Skip to content

Commit

Permalink
internal/components: enable datadogprocessor (open-telemetry#16607)
Browse files Browse the repository at this point in the history
* Add datadogprocessor.

* internal/components: add datadogprocessor to lifecycle tests

* restart
  • Loading branch information
gbbr authored Dec 19, 2022
1 parent 62da158 commit 47db6ba
Show file tree
Hide file tree
Showing 8 changed files with 37 additions and 0 deletions.
16 changes: 16 additions & 0 deletions .chloggen/gbbr_datadogprocessor.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: new_component

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: processor/datadogprocessor

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: The Datadog Processor is used to compute pre-sampling APM Stats.

# One or more tracking issues related to the change
issues: [15689]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: Use it to get full visibility into APM Stats in conjunction with the Collector's tail sampling processors.
4 changes: 4 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,10 @@ updates:
directory: "/processor/cumulativetodeltaprocessor"
schedule:
interval: "weekly"
- package-ecosystem: "gomod"
directory: "/processor/datadogprocessor"
schedule:
interval: "weekly"
- package-ecosystem: "gomod"
directory: "/processor/deltatorateprocessor"
schedule:
Expand Down
3 changes: 3 additions & 0 deletions cmd/configschema/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/datadogprocessor v0.0.0-00010101000000-000000000000 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatorateprocessor v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbyattrsprocessor v0.67.0 // indirect
Expand Down Expand Up @@ -818,6 +819,8 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/attr

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor => ../../processor/cumulativetodeltaprocessor/

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/datadogprocessor => ../../processor/datadogprocessor/

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatorateprocessor => ../../processor/deltatorateprocessor/

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor => ../../processor/filterprocessor
Expand Down
3 changes: 3 additions & 0 deletions cmd/otelcontribcol/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/winperfcounters v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/datadogprocessor v0.0.0-00010101000000-000000000000 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatorateprocessor v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.67.0 // indirect
github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbyattrsprocessor v0.67.0 // indirect
Expand Down Expand Up @@ -820,6 +821,8 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/grou

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor => ../../processor/cumulativetodeltaprocessor

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/datadogprocessor => ../../processor/datadogprocessor

replace github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecstaskobserver => ../../extension/observer/ecstaskobserver

replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/zookeeperreceiver => ../../receiver/zookeeperreceiver
Expand Down
2 changes: 2 additions & 0 deletions cmd/oteltestbedcol/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -631,3 +631,5 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/stats
replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/simpleprometheusreceiver => ../../receiver/simpleprometheusreceiver

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/probabilisticsamplerprocessor => ../../processor/probabilisticsamplerprocessor

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/datadogprocessor => ../../processor/datadogprocessor
3 changes: 3 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza v0.67.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.67.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor v0.67.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/datadogprocessor v0.0.0-00010101000000-000000000000
github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatorateprocessor v0.67.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.67.0
github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbyattrsprocessor v0.67.0
Expand Down Expand Up @@ -818,6 +819,8 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/attr

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor => ./processor/cumulativetodeltaprocessor/

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/datadogprocessor => ./processor/datadogprocessor

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatorateprocessor => ./processor/deltatorateprocessor/

replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor => ./processor/filterprocessor
Expand Down
2 changes: 2 additions & 0 deletions internal/components/components.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ import (
"github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/filestorage"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/cumulativetodeltaprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/datadogprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/deltatorateprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor"
"github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbyattrsprocessor"
Expand Down Expand Up @@ -369,6 +370,7 @@ func Components() (otelcol.Factories, error) {
spanmetricsprocessor.NewFactory(),
spanprocessor.NewFactory(),
cumulativetodeltaprocessor.NewFactory(),
datadogprocessor.NewFactory(),
deltatorateprocessor.NewFactory(),
transformprocessor.NewFactory(),
}
Expand Down
4 changes: 4 additions & 0 deletions internal/components/processors_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ func TestDefaultProcessors(t *testing.T) {
{
processor: "batch",
},
{
processor: "datadog",
skipLifecycle: true, // requires external exporters to be configured to route data
},
{
processor: "deltatorate",
},
Expand Down

0 comments on commit 47db6ba

Please sign in to comment.