Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/components: enable datadogprocessor #16607

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

gbbr
Copy link
Member

@gbbr gbbr commented Dec 5, 2022

Closes #15689

@github-actions github-actions bot added cmd/configschema configschema command exporter/datadog Datadog components labels Dec 5, 2022
@runforesight
Copy link

runforesight bot commented Dec 5, 2022

Foresight Summary

    
Major Impacts

TestRabbitmqIntegration ❌ failed 1 times in 13 runs (7% fail rate).
TestRabbitmqIntegration/Running_rabbitmq_3.9 ❌ failed 1 times in 13 runs (7% fail rate).
build-and-test-windows duration(4 seconds) has decreased 42 minutes 40 seconds compared to main branch avg(42 minutes 44 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (42 minutes 40 seconds less than main branch avg.) and finished at 19th Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 45 seconds (2 minutes 47 seconds less than main branch avg.) and finished at 19th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 59 seconds (2 minutes 54 seconds less than main branch avg.) and finished at 19th Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  changelog workflow has finished in 1 minute 47 seconds (6 minutes 59 seconds less than main branch avg.) and finished at 19th Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

 prometheus-compliance-tests workflow has finished in 9 seconds (9 minutes 43 seconds less than main branch avg.) and finished at 19th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 8 minutes 2 seconds (9 minutes 21 seconds less than main branch avg.) and finished at 19th Dec, 2022.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

 build-and-test workflow has finished in 9 minutes 57 seconds (50 minutes 18 seconds less than main branch avg.) and finished at 19th Dec, 2022.


Job Failed Steps Tests
unittest-matrix (1.18, internal) N/A  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) N/A  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics N/A  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) N/A  ✅ 1474  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 1474  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 2539  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 2539  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 2456  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) N/A  ✅ 2456  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 4394  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 4394  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) N/A  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
integration-tests N/A  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@gbbr gbbr force-pushed the gbbr/datadogprocessor branch 3 times, most recently from 8ec3e93 to 8237fd7 Compare December 8, 2022 11:17
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Dec 8, 2022
@gbbr gbbr force-pushed the gbbr/datadogprocessor branch 3 times, most recently from fea3326 to 426fcc0 Compare December 8, 2022 14:10
@gbbr gbbr marked this pull request as ready for review December 8, 2022 14:10
@gbbr gbbr requested a review from a team December 8, 2022 14:10
@gbbr gbbr requested review from mx-psi and dmitryax as code owners December 8, 2022 14:10
@gbbr gbbr changed the title processor/datadogprocessor: initial implementation processor: add datadogprocessor Dec 8, 2022
@gbbr gbbr force-pushed the gbbr/datadogprocessor branch from 426fcc0 to c4aab5d Compare December 8, 2022 14:16
@gbbr gbbr force-pushed the gbbr/datadogprocessor branch 7 times, most recently from 1dffda1 to 53a0bd0 Compare December 8, 2022 20:12
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split this PR in accordance to the contributing guidelines for new components?

The Datadog exporter changes should also be on a separate PR

@gbbr gbbr force-pushed the gbbr/datadogprocessor branch from 53a0bd0 to 0d0e8dd Compare December 12, 2022 10:32
@gbbr gbbr marked this pull request as draft December 12, 2022 10:49
@gbbr gbbr changed the title processor: add datadogprocessor [draft]processor: add datadogprocessor Dec 12, 2022
@gbbr gbbr force-pushed the gbbr/datadogprocessor branch from 0d0e8dd to c28cc50 Compare December 12, 2022 14:01
@github-actions github-actions bot requested a review from pmcollins December 12, 2022 14:01
@gbbr gbbr force-pushed the gbbr/datadogprocessor branch from c28cc50 to 08973c5 Compare December 13, 2022 12:06
@gbbr gbbr changed the title [draft]processor: add datadogprocessor internal/components: enable datadogprocessor Dec 13, 2022
@gbbr gbbr marked this pull request as ready for review December 13, 2022 12:08
@gbbr gbbr requested review from mx-psi and removed request for pmcollins December 13, 2022 12:08
@mx-psi mx-psi added processor/datadog and removed exporter/datadog Datadog components labels Dec 15, 2022
@github-actions github-actions bot requested a review from dineshg13 December 15, 2022 10:52
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want to wait until the unit tests situation is solved (see #17037)

@mx-psi
Copy link
Member

mx-psi commented Dec 15, 2022

 === RUN   TestDefaultProcessors
    processors_test.go:142: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/components/processors_test.go:142
        	Error:      	"[{attributes %!s(components.getProcessorConfigFn=0x83b2c40) %!s(bool=false)} {batch %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {deltatorate %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {filter %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {groupbyattrs %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {groupbytrace %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {k8sattributes %!s(components.getProcessorConfigFn=<nil>) %!s(bool=true)} {memory_limiter %!s(components.getProcessorConfigFn=0x83b2b40) %!s(bool=false)} {metricstransform %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {experimental_metricsgeneration %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {probabilistic_sampler %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {resourcedetection %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {resource %!s(components.getProcessorConfigFn=0x83b2960) %!s(bool=false)} {routing %!s(components.getProcessorConfigFn=<nil>) %!s(bool=true)} {span %!s(components.getProcessorConfigFn=0x83b2800) %!s(bool=false)} {servicegraph %!s(components.getProcessorConfigFn=<nil>) %!s(bool=true)} {spanmetrics %!s(components.getProcessorConfigFn=<nil>) %!s(bool=true)} {cumulativetodelta %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {tail_sampling %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)} {transform %!s(components.getProcessorConfigFn=<nil>) %!s(bool=false)}]" should have 21 item(s), but has 20
        	Test:       	TestDefaultProcessors
        	Messages:   	All processors MUST be added to lifecycle tests

@mx-psi mx-psi force-pushed the gbbr/datadogprocessor branch from 08973c5 to 15e4388 Compare December 19, 2022 10:58
@github-actions github-actions bot requested a review from pmcollins December 19, 2022 10:59
@gbbr gbbr force-pushed the gbbr/datadogprocessor branch from d4af20c to 00453ff Compare December 19, 2022 12:14
@mx-psi mx-psi merged commit 47db6ba into open-telemetry:main Dec 19, 2022
@gbbr gbbr deleted the gbbr/datadogprocessor branch December 19, 2022 14:22
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component: processor/datadog
4 participants