-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack notifier implementation #1
Conversation
Squashed newer commits for clarity, |
As discussed with @mcass19, I replaced the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🚀 🚀
Leave some minor things. Some of them are more opinionated syntactic things, so feel free to ignore all what you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
Description
Adds main functionality for the slack notifier
Notes for reviewers
The notifier implementation parts from Boom version 0.8.0 which hasn't been released yet.In order to run tests, a local version of boom 0.8.0 must be set up, e.g.{:boom_notifier, path: "../boom"},
Additionally, to run locally, you'll have to specify a
slack_webhook_url
as described in the readme, instructions are also provided for creating a new slack application and setting up a webhook.Screenshots