Refactor error storage data #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaguirre88
force-pushed
the
group-errors-by-hash
branch
2 times, most recently
from
e71e5be to
97d0294
Compare
Currently, we are grouping every error information in several lists according to its error type. Eventually, this could consume a lot of memory without providing any important benefit (the only piece of information that changes is the timestamp and the request data). This commit replaces that with a map structure where its key is the hashed error info and its value is the actual error info plus: * the number of times this error occurred, * the first and the list time it happened.
iaguirre88
force-pushed
the
group-errors-by-hash
branch
from
97d0294 to
da24a16
Compare
mcass19
previously approved these changes
Apr 11, 2022
There was a problem hiding this comment.
🚀 🚀 🚀
Really like how this ended!!! Also like the use of the first entry of the stacktrace for the hash key (but not entirely).
I think we need to update the readme in the Custom Notifiers section, right? I was also thinking that maybe it's worth to let the user know in that part of the readme something of what that ErrorInfo struct could have? (I know it's in the code, but just for attract more 😛)
lib/boom_notifier/error_storage.ex
Outdated
| accumulated_occurrences = Map.get(error_storage_item, :accumulated_occurrences) | ||
| max_storage_capacity = Map.get(error_storage_item, :__max_storage_capacity__) | ||
|
|
||
| if accumulated_occurrences >= max_storage_capacity, do: true, else: false |
There was a problem hiding this comment.
NIT: is this if necessary? 😅
mcass19
previously approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change
Currently, we are grouping every error information in several lists
according to its error type. Eventually, this could consume a lot of
memory without providing any important benefit (the only piece of
information that changes is the timestamp and the request data).
This commit replaces that with a map structure where its key is the
hashed error info and its value is the actual error info plus:
Email example:
Webhook example: