-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airframe-http: Add HttpClient #482
Conversation
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 83.79% 83.62% -0.18%
==========================================
Files 193 200 +7
Lines 7586 7919 +333
Branches 684 699 +15
==========================================
+ Hits 6357 6622 +265
- Misses 1229 1297 +68
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xerial Thanks for your great work! I have some questions on it just to be sure. Please can you take a look?
airframe-http/src/main/scala/wvlet/airframe/http/HttpClient.scala
Outdated
Show resolved
Hide resolved
airframe-http/src/main/scala/wvlet/airframe/http/HttpClient.scala
Outdated
Show resolved
Hide resolved
airframe-http/src/main/scala/wvlet/airframe/http/HttpClient.scala
Outdated
Show resolved
Hide resolved
airframe-http/src/main/scala/wvlet/airframe/http/HttpClient.scala
Outdated
Show resolved
Hide resolved
airframe-http-finagle/src/main/scala/wvlet/airframe/http/finagle/FinagleClient.scala
Show resolved
Hide resolved
airframe-http-finagle/src/main/scala/wvlet/airframe/http/finagle/FinagleRetryFilter.scala
Outdated
Show resolved
Hide resolved
CI is failing because of jdk11 download failure. Other than that, we are good to merge this PR. |
@xerial Thanks for your quick fix! |
Add a common interface and finagle-based implementation for an http client. #472