Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retryer -> RetryContext #491

Closed
xerial opened this issue Apr 16, 2019 · 1 comment
Closed

Retryer -> RetryContext #491

xerial opened this issue Apr 16, 2019 · 1 comment

Comments

@xerial
Copy link
Member

xerial commented Apr 16, 2019

Rather than integrating retry execution logic, separating RetryContext (e.g., retryCount, retryPolicy, etc.) found to be useful during the implementation of #482 to support varieties for retry execution, such as retrying using Future.
@xerial xerial mentioned this issue Apr 16, 2019
Merged
8 tasks
xerial added a commit that referenced this issue Apr 18, 2019
@xerial
airframe-http: Add HttpClient (#482)
4bb9463 
- airframe-control: Simplify Retryer (=> RetryContext) to support http error handling #467 #491
- Add HttpStatus code representations using type classes (xxxAdapter)
- Add a standard HTTP response hander #366
-  Add a finagle-based HTTP client
-  Add async/sync http clients. Using F[_] as an abstraction of Future. This is useful to remove the dependency to Finagle in airframe-http.
-  Support circuit breaker (No code for this. We can use circuit breaker of Finagle by customizing FinagleClientConfig.initClient)
-  Integrate control.Retry and FinagleRetryFilter.
- Finagle will not enable request retry by default, so we anyway need to add our own retry filter.
- Simplified control.Retry so that we can use this retry logic both for imperative programming and Future-based programming.
- Support response/request -> object mapping with airframe-codec.
@xerial
Copy link
Member Author

xerial commented Apr 23, 2019

Done in #482

@xerial xerial closed this as completed Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xerial