Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed HTML templates in server executable #20

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Embed HTML templates in server executable #20

merged 1 commit into from
Apr 4, 2024

Conversation

kjsanger
Copy link
Member

@kjsanger kjsanger commented Apr 3, 2024 •
edited
Loading

The templates had to move from the root directory into a directory level with the server package because

  1. Go does not allow the embedding directive to reference paths upwards (..)
  2. Symbols in the main package can't be exported and there can only be one package per filesystem directory, so we can't load the templates from there and export them to the server package

@kjsanger
Embed HTML templates in executable
95a22b5 
Refactoring around templates and main function.
@kjsanger kjsanger force-pushed the feature/embed-templates branch from 60e68dd to 95a22b5 Compare April 4, 2024 10:21
@mksanger mksanger merged commit 98a2e9e into wtsi-npg:devel Apr 4, 2024
5 checks passed
@kjsanger kjsanger deleted the feature/embed-templates branch April 4, 2024 11:07
@kjsanger kjsanger mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjsanger @mksanger