Modified/Corrected LECH's stability functions in the SL Urban Canopy Model following the formulation. #2032

joshi994 · 2024-04-01T16:28:08Z

TYPE: Bug fix

KEYWORDS: LECH stability functions, Latent heat flux, Sensible heat flux, SL Urban Canpy Model

SOURCE: Parag Joshi (Brookhaven National Lab), Katia Lamer (Brookhaven National Lab)

DESCRIPTION OF CHANGES:
Problem:
The stability functions originally proposed by Lech Lobocki which are used in calculating the exchange coefficients between surface layer and roof, building wall, Green roof, and ground are implemented incorrectly. The error surfaced while comparing the formulation suggested in Lobocki 1992 with the equations in commands/lines 3056 and 3062 (WRF-v4.5.2).

Solution:
The code has been corrected by referring to the equations 48 and 49 of the article "A procedure for the derivation of surface layer bulk relationships from simplified second-order closure models" by Lobocki 1992 (Journal of Applied Meteorology).

LIST OF MODIFIED FILES:
M phys/module_sf_urban.F

TESTS CONDUCTED:

The significance of the corrections can be highlighted by comparing a test run with the corrected module and current version of the WRF model.
The fix will correct the evaluation of the exchange coefficients between the ground, roof, green roof etc and air.
The Jenkins tests are all passing.

RELEASE NOTE: Lech's stability functions are corrected following the original formulation.

KEYWORDS: LECH stability functions, Latent heat flux, Sensible heat flux, energy balance, Surface temperature, SL Urban Canpy Model SOURCE: Parag Joshi (Brookhaven National Lab), Katia Lamer (Brookhaven National Lab) DESCRIPTION OF CHANGES: Problem: The stabvility functions originally proposed by Lech Lobocki which are used in calculating the exchange coefficients between surface layer and roof, building wall, Green roof, and ground are implemented incorrectly. The error surfaced while comparing the formulation suggested in Lobocki 1992 with the equations in commands/lines 3056 and 3062 (WRF-v4.5.2). Solution: The code has been corrected by referring to the equations 48 and 49 of the article "A procedure for the derivation of surface layer bulk relationahips from simplified second-order closure models" by Lobocki 1992 (Journal of Applied Meteorology). LIST OF MODIFIED FILES: module_sf_urban.F

joshi994 · 2024-04-01T16:31:24Z

Please refer to the attached.

weiwangncar · 2024-04-07T20:13:03Z

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

weiwangncar · 2024-04-07T20:14:23Z

@cenlinhe Can you review this PR? Thanks!

cenlinhe · 2024-04-08T23:05:15Z

OK, this is indeed a bug and the proposed fix looks correct to me. I guess this error came from the original code of Noah LSM SFCDIF subroutine based on Chen et al., (1997, BLM): https://link.springer.com/article/10.1023/A:1000531001463
which was copied and pasted to the urban part. The paper shows the correct equations (A7 and A8 in the appendix) but the code implementation is wrong.
The current Noah-MP SFCDIF2 subroutine (based on Chen et al., 1997) also has this bug: https://github.com/NCAR/noahmp/blob/noahmp_v4.5_develop/src/module_sf_noahmplsm.F#L4810-L4813
which needs to be fixed too.
@dudhia @barlage

dudhia

I approve and defer to others on details of this.

The base branch was changed.

weiwangncar · 2024-04-11T02:02:43Z

@cenlinhe Thanks for reviewing this PR. Would you approve this?

cenlinhe · 2024-04-11T04:20:40Z

@cenlinhe Thanks for reviewing this PR. Would you approve this?

Yes, I approve this. @tslin2 could you please also take a look when you have time?

dudhia

I approve and defer to others on details of this.

joshi994 · 2024-04-12T18:59:12Z

@cenlinhe Should I go ahead an make changes in the MoahMP-SFCDIF2 as well or you are going to update the subroutine?

cenlinhe · 2024-04-12T22:41:29Z

@cenlinhe Should I go ahead an make changes in the MoahMP-SFCDIF2 as well or you are going to update the subroutine?

No, you do not need to do it. I will fix them later.

tslin2 · 2024-04-13T00:20:16Z

@cenlinhe Thanks for reviewing this PR. Would you approve this?

Yes, I approve this. @tslin2 could you please also take a look when you have time?

I will try to look at this next week!

cenlinhe · 2024-04-17T18:48:03Z

@joshi994 do you have a reference showing the equations for your latest bug fix commit?

joshi994 · 2024-04-17T18:53:33Z

@joshi994 do you have a reference showing the equations for your latest bug fix commit?

@cenlinhe I messed up in my latest commit. I have submitted a different pull request. Please refer to the link:
#2038

cenlinhe · 2024-04-17T20:41:26Z

@joshi994 do you have a reference showing the equations for your latest bug fix commit?

@cenlinhe I messed up in my latest commit. I have submitted a different pull request. Please refer to the link: #2038

OK, I think you may need to revert back to the original commit by removing the latest one, otherwise this PR seems being messed up.

cenlinhe · 2024-04-17T20:43:17Z

Your previous changes seems gone. They were replaced by your latest code changes.

joshi994 · 2024-04-17T20:57:03Z

Your previous changes seems gone. They were replaced by your latest code changes.

@cenlinhe I am new to GitHub commit. I may need some time to correct the error. What do you suggest?

cenlinhe · 2024-04-17T20:59:19Z

Your previous changes seems gone. They were replaced by your latest code changes.

@cenlinhe I am new to GitHub commit. I may need some time to correct the error. What do you suggest?

Sounds good. It's OK for you to take some time to correct this error. Thanks.

joshi994 · 2024-04-17T22:08:23Z

Your previous changes seems gone. They were replaced by your latest code changes.

@cenlinhe I am new to GitHub commit. I may need some time to correct the error. What do you suggest?

Sounds good. It's OK for you to take some time to correct this error. Thanks.

@cenlinhe I tried reverting the error. Can you please confirm if the changes are restored and the new PR is still there?

cenlinhe · 2024-04-17T22:09:50Z

looks like this PR is reverted back and correct now. the new PR (2038) is also there. When you make any changes to your new PR (2038), please make sure you are working on your "my_changes2" branch instead of "my_changes1" branch. The "my_changes1" branch is for this PR here.

joshi994 · 2024-04-17T22:11:43Z

Thanks for confirming. Please let me know if you need further clarification. From: Cenlin_He ***@***.***> Date: Wednesday, April 17, 2024 at 6:10 PM To: wrf-model/WRF ***@***.***> Cc: Joshi, Parag ***@***.***>, Mention ***@***.***> Subject: Re: [wrf-model/WRF] Modified/Corrected LECH's stability functions in the SL Urban Canopy Model following the formulation. (PR #2032) looks like this PR is reverted back and correct now. — Reply to this email directly, view it on GitHub<#2032 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGF4AMW34XMKR7QKUWZGJVDY53XMJAVCNFSM6AAAAABFR3BMUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGUZTCMRZGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

cenlinhe · 2024-04-17T22:13:41Z

@joshi994 just to double check. please see if this is your original PR bug fix code changes: https://github.com/wrf-model/WRF/pull/2032/files
I think it is.

joshi994 · 2024-04-18T13:38:50Z

@joshi994 just to double check. please see if this is your original PR bug fix code changes: https://github.com/wrf-model/WRF/pull/2032/files I think it is.

@cenlinhe Yes, this is the original PR bug fix changes. I accidentally hit my_changes1 for the new PR (#2038) and that's what caused the issue. Thanks for your response.

See CORDEX-WRF-community/fps-urb-rcc#6 Correction scheduled to appear in WRF v4.6. This still needs to be corrected in Noah MP to be complete. See wrf-model#2032

See NCAR#123 in the refactored code and wrf-model/WRF#2032 This is paired to CORDEX-WRF-community/WRF@225661d in SLUCM

No code change, just cleaner since one of Lech Lobocki's equations for heat (PSLHS) was under the Paulson equations (PSP..) section. See eq. A5-8 in https://doi.org/10.1023/A:1000531001463 and wrf-model#2032

jesusff · 2024-04-19T10:31:36Z

Hi, you might want to take the opportunity to move the misplaced Lech equation to its place, as in my last commit above CORDEX-WRF-community@1a2492c

tslin2 · 2024-06-15T20:47:50Z

@cenlinhe Thanks for reviewing this PR. Would you approve this?

Yes, I approve this. @tslin2 could you please also take a look when you have time?

I will try to look at this next week!

yes, the changes is consistent with the papers.

weiwangncar · 2024-08-06T10:45:57Z

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

weiwangncar · 2024-08-06T10:46:46Z

@cenlinhe Can you approve this PR?

cenlinhe · 2024-08-06T15:03:32Z

I approve this.

weiwangncar

Acting for Cenlin.

dudhia

Any idea of the size of the difference?

joshi994 requested a review from a team as a code owner April 1, 2024 16:28

weiwangncar changed the base branch from master to develop April 7, 2024 20:09

dudhia previously approved these changes Apr 11, 2024

View reviewed changes

weiwangncar changed the base branch from develop to release-v4.6.0 April 11, 2024 01:44

weiwangncar added the release-v4.6.0 label Apr 11, 2024

weiwangncar previously approved these changes Apr 11, 2024

View reviewed changes

dudhia previously approved these changes Apr 12, 2024

View reviewed changes

joshi994 dismissed stale reviews from dudhia and weiwangncar via 45a820b April 17, 2024 18:05

joshi994 force-pushed the my_changes1 branch from 12f6f66 to 45a820b Compare April 17, 2024 18:05

joshi994 force-pushed the my_changes1 branch from 45a820b to 12f6f66 Compare April 17, 2024 22:03

cenlinhe mentioned this pull request Apr 18, 2024

bug fix for LECH SURFACE FUNCTIONS in Chen97 NCAR/noahmp#123

Merged

jesusff added a commit to CORDEX-WRF-community/noahmp that referenced this pull request Apr 19, 2024

Corrected LECH's stability functions

e348cac

See NCAR#123 in the refactored code and wrf-model/WRF#2032 This is paired to CORDEX-WRF-community/WRF@225661d in SLUCM

weiwangncar added Develop Branch and removed release-v4.6.0 labels Apr 29, 2024

weiwangncar changed the base branch from release-v4.6.0 to release-v4.6.1 August 6, 2024 08:11

remove a blank line in module_sf_urban.F to trigger the test.

b831f7f

weiwangncar added release-v4.6.1 and removed Develop Branch labels Aug 6, 2024

weiwangncar approved these changes Aug 7, 2024

View reviewed changes

dudhia approved these changes Aug 19, 2024

View reviewed changes

weiwangncar merged commit ae6c321 into wrf-model:release-v4.6.1 Aug 20, 2024
1 of 4 checks passed

cenlinhe mentioned this pull request Jan 29, 2025

sync with urban bug fix included in WRF and Noah-MP bug fix NCAR/hrldas#240

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modified/Corrected LECH's stability functions in the SL Urban Canopy Model following the formulation. #2032

Modified/Corrected LECH's stability functions in the SL Urban Canopy Model following the formulation. #2032

joshi994 commented Apr 1, 2024 •

edited by weiwangncar

Loading

joshi994 commented Apr 1, 2024

weiwangncar commented Apr 7, 2024

weiwangncar commented Apr 7, 2024

cenlinhe commented Apr 8, 2024 •

edited

Loading

dudhia left a comment

weiwangncar commented Apr 11, 2024

cenlinhe commented Apr 11, 2024

dudhia left a comment

joshi994 commented Apr 12, 2024

cenlinhe commented Apr 12, 2024

tslin2 commented Apr 13, 2024

cenlinhe commented Apr 17, 2024

joshi994 commented Apr 17, 2024 •

edited

Loading

cenlinhe commented Apr 17, 2024

cenlinhe commented Apr 17, 2024

joshi994 commented Apr 17, 2024

cenlinhe commented Apr 17, 2024

joshi994 commented Apr 17, 2024

cenlinhe commented Apr 17, 2024 •

edited

Loading

joshi994 commented Apr 17, 2024 via email

cenlinhe commented Apr 17, 2024

joshi994 commented Apr 18, 2024

jesusff commented Apr 19, 2024

tslin2 commented Jun 15, 2024

weiwangncar commented Aug 6, 2024

weiwangncar commented Aug 6, 2024

cenlinhe commented Aug 6, 2024

weiwangncar left a comment

dudhia left a comment

Modified/Corrected LECH's stability functions in the SL Urban Canopy Model following the formulation. #2032

Modified/Corrected LECH's stability functions in the SL Urban Canopy Model following the formulation. #2032

Conversation

joshi994 commented Apr 1, 2024 • edited by weiwangncar Loading

joshi994 commented Apr 1, 2024

weiwangncar commented Apr 7, 2024

weiwangncar commented Apr 7, 2024

cenlinhe commented Apr 8, 2024 • edited Loading

dudhia left a comment

Choose a reason for hiding this comment

weiwangncar commented Apr 11, 2024

cenlinhe commented Apr 11, 2024

dudhia left a comment

Choose a reason for hiding this comment

joshi994 commented Apr 12, 2024

cenlinhe commented Apr 12, 2024

tslin2 commented Apr 13, 2024

cenlinhe commented Apr 17, 2024

joshi994 commented Apr 17, 2024 • edited Loading

cenlinhe commented Apr 17, 2024

cenlinhe commented Apr 17, 2024

joshi994 commented Apr 17, 2024

cenlinhe commented Apr 17, 2024

joshi994 commented Apr 17, 2024

cenlinhe commented Apr 17, 2024 • edited Loading

joshi994 commented Apr 17, 2024 via email

cenlinhe commented Apr 17, 2024

joshi994 commented Apr 18, 2024

jesusff commented Apr 19, 2024

tslin2 commented Jun 15, 2024

weiwangncar commented Aug 6, 2024

weiwangncar commented Aug 6, 2024

cenlinhe commented Aug 6, 2024

weiwangncar left a comment

Choose a reason for hiding this comment

dudhia left a comment

Choose a reason for hiding this comment

joshi994 commented Apr 1, 2024 •

edited by weiwangncar

Loading

cenlinhe commented Apr 8, 2024 •

edited

Loading

joshi994 commented Apr 17, 2024 •

edited

Loading

cenlinhe commented Apr 17, 2024 •

edited

Loading