bug fix for LECH SURFACE FUNCTIONS in Chen97 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAbolafiaRosenzweig
approved these changes
Apr 18, 2024
tslin2
approved these changes
Apr 18, 2024
jesusff
added a commit
to CORDEX-WRF-community/noahmp
that referenced
this pull request
Apr 19, 2024
See NCAR#123 in the refactored code and wrf-model/WRF#2032 This is paired to CORDEX-WRF-community/WRF@225661d in SLUCM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for the LECH's surface function in Chen et al. 1997 surface resistance module calculations. This bug and fix were identified in WRF PR: wrf-model/WRF#2032
The WRF PR above provides the reason and original reference for the correct equations. Note that the equations in Chen et al. 1997 are correct, but the current code shows the wrong equation.