Replace XML formatter and add format shortcut #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #141 There were a few issues with our previous XML formatter, the biggest one is that it would behave differently than Blueprint formatter. So I wrote a custom XML formatter that behaves exactly like Blueprint xml_emitter.py . https://gitlab.gnome.org/jwestman/blueprint-compiler/-/blob/59283a76adc8d270ff5f67b630b7dfa905ec34a9/blueprintcompiler/xml_emitter.py
sonnyp
commented
Aug 17, 2022
|
There's something wrong while formatting XMLs like this: <?xml version="1.0" encoding="UTF-8"?>
<interface>
<object class="GtkBox"></object>
</interface>It deletes code every time I press the shortcut. |
|
@melix99 nice catch — it's fixed |
|
Another thing I discovered is that the formatter is a bit too destructive when when the xml is not valid: <?xml version="1.0" encoding="UTF-8"?>
<interface>
<object class="GtkBox" hey/>
</interface>Is formatted to: <?xml version="1.0" encoding="UTF-8"?>
<interface>I think it's better to just do nothing or showing an error when the xml is invalid instead of deleting code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shortcut is
<Ctrl><Shift>Return.There were a few issues with our previous XML formatter, the biggest one is that it would behave differently than Blueprint formatter. So I wrote a custom XML formatter that behaves exactly like Blueprint xml_emitter.py .
https://gitlab.gnome.org/jwestman/blueprint-compiler/-/blob/59283a76adc8d270ff5f67b630b7dfa905ec34a9/blueprintcompiler/xml_emitter.py
@melix99 could you test this quickly? Building this branch in GNOME Builder should work just fine.
Feel free to review as well but that's not required .