Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support XML comments when formatting code #144

Open
2 tasks
sonnyp opened this issue Aug 22, 2022 · 0 comments
Open
2 tasks

Support XML comments when formatting code #144

sonnyp opened this issue Aug 22, 2022 · 0 comments

Comments

@sonnyp
Copy link
Contributor

sonnyp commented Aug 22, 2022

Right now, if the XML UI contains comments, they will get removed when the code is formatted (Ctrl+Shift+Return or Run).

This is quite annoying as the user might have spent time writing those comments, and they will get deleted. Fortunately it's possible to "undo" the formatting.

Let's support XML comments - for that we need

  • Make ltx sax-like parser emit XML comments
  • Update Workbench format function to use and append comments
@sonnyp sonnyp added the help wanted Extra attention is needed label Aug 22, 2022
@sonnyp sonnyp mentioned this issue Aug 22, 2022
Merged
@sonnyp sonnyp removed the help wanted Extra attention is needed label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sonnyp