-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for node.rel crash #630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get the mentioned red screen to pop-up.
Thanks for the pass @diegoreymendez ! I will actually need to update this PR to host a different solution as, I closed the Gutenberg side PR as invalid. Will report here again soon. |
This reverts commit e29115e.
Ready for another pass! This time, the solution uses this PR opened against the |
I think this will make a lot of things easier. Does this mean we can move some (maybe all?) of the jsdom-patches? |
Most probably, but let's wait until after our release this coming days so we don't shake things up too much. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I can't manage to reproduce the original issue. Nice work!
Addresses at least one case of "Pasting from some sources causes a red screen (related comment)" from #624
To test: