Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't normalize stings, check for object instead #1

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Don't normalize stings, check for object instead #1

merged 1 commit into from
Feb 21, 2019

Conversation

hypest
Copy link

@hypest hypest commented Feb 21, 2019

Hello 👋

This PR adds a fix for the "argument does not match any normalization form" as seen in wordpress-mobile/gutenberg-mobile#617 (review).

It follows the same logic as in line 95 earlier in the same file, guard the call to n.normalize() with a check for type object.

h/t to @koke for spotting the bug.

@iamcco
Copy link
Owner

iamcco commented Feb 21, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants