Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShouldInsertAtTheTop setting calculation #3538

Merged
merged 4 commits into from
May 24, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 21, 2021

gutenberg PR: WordPress/gutenberg#32110

Fixes the issue identified after merging the reusable block PR into develop (UI test reference).

To test:
Follow testing instructions from Gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the [Type] Bug Something isn't working label May 21, 2021
@fluiddot fluiddot added this to the 1.54.0 (17.5) milestone May 21, 2021
@fluiddot fluiddot requested review from dcalhoun and geriux May 21, 2021 18:20
@fluiddot fluiddot self-assigned this May 21, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 24, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot
Copy link
Contributor Author

All tests (including optional) were 🟢 in the previous commit to the update with the merge commit.

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot fluiddot merged commit 67fcf4f into develop May 24, 2021
@fluiddot fluiddot deleted the fix/insertion-point-title-selected branch May 24, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants