[RNMobile] Fix ShouldInsertAtTheTop setting calculation
#32110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
2 tasks
|
Size Change: -36 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
|
Hey @fluiddot 👋 I was doing some testing and found an issue where after finishing the testing steps, if I select the second block and try to add a new one the TestiOS.mov |
I experienced that too but I don't think it's related to these changes because it can be also reproduced on production (I tested on version WPiOS EDIT: If you type after selecting a paragraph block then the insertion point is correct 🤷♂️ . |
You're right, I checked it and it's the same. Alright, we should open an issue to track it 😄 One question, does it work for you on Android? It is not working for me but I wanna double-check is not an issue on my side and the local build: AndroidTest.mov |
Ok, I'll open an issue as soon as possible.
Nope, it doesn't work either for me, it's happening the same as on iOS. After selecting the title, it always shows the insertion point at the beginning of the post. |
geriux
approved these changes
May 24, 2021
|
@geriux could you take a look at the GB-mobile PR related to this one? Thanks 🙇 ! |
I've just opened this issue with the problem you spotted, thanks for your help 🙇 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3538Description
When the title is selected, we enforce the insertion point to be
index: 0by a setting named__experimentalShouldInsertAtTheTop(code reference). This setting was being calculated inuseBlockEditorSettingsbut after the changes introduced in the reusable block PR, now the settings specific to the native version are calculated and memoized in the native version ofuseBlockEditorSettingsso as the setting wasn't included then the value never updates.This PR basically moves the calculation of
__experimentalShouldInsertAtTheTopto the native version ofuseBlockEditorSettings.How has this been tested?
Screenshots
insertion-point-test.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).