Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.44.1 #3006

Merged
merged 9 commits into from
Jan 15, 2021
Merged

Release 1.44.1 #3006

merged 9 commits into from
Jan 15, 2021

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Jan 14, 2021

Release for Gutenberg Mobile 1.44.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 14, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jd-alexander
Copy link
Contributor

jd-alexander commented Jan 14, 2021

I am re-running the failed UI Tests for Android and iOS. The failure was due to the File Block UI tests that have failed in the past. I had created a PR that increased sleep time on Android before a click operation that was causing the failure. That change was just merged so it's not included here. I will keep an eye out for this on other PRs to ensure it's not taking place.

@cameronvoell cameronvoell marked this pull request as ready for review January 15, 2021 00:38
@jd-alexander
Copy link
Contributor

jd-alexander commented Jan 15, 2021

@cameronvoell for the bundle updates. Do we run the bundle update command every time we update the Gutenberg ref? I just noticed that after the last GB ref update it wasn't updated so let me know if that's expected.

Update

This question was answered by @cameronvoell The bundles are only updated when the Gutenberg ref update contains code changes. The last Gutenberg ref update that was made is related to a changelog commit.

Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@cameronvoell
Copy link
Contributor Author

@cameronvoell for the bundle updates. Do we run the bundle update command every time we update the Gutenberg ref? I just noticed that after the last GB ref update it wasn't updated so let me know if that's expected.

The bundle has no changes and doesnt require an update because the latest changes were only to release-notes and gutenberg change log. In the future I'll try and avoid making those the last updates on the PR because I agree the reference update with no bundle update after looks scary. I re-ran the bundle command just to be extra sure and verified it shows no changes (since I ran it on my machine last and no updates to relevant files since then).

@cameronvoell
Copy link
Contributor Author

cameronvoell commented Jan 15, 2021

I did writing flow tests for iOS and Android just to be safe and everything looks good with no regressions 🎉

General

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@cameronvoell cameronvoell merged commit d2b8cbe into trunk Jan 15, 2021
@cameronvoell cameronvoell deleted the release/1.44.1 branch January 15, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants