-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gutenberg-mobile release 1.44.1 #15644
Integrate gutenberg-mobile release 1.44.1 #15644
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the features being added with this beta fix are functioning as expected. Below are the steps, I followed.
Font Size
1. I created a post with a paragraph on Calypso.
2. I added a paragraph and set a custom font size so that a font size with the px
value would be returned programmatically when
3. I can confirm that on my iPhone 11 with this build, I did not get a crash when I opened the post. I can also confirm that the paragraph was visible.
Block Mover
1. I utilized the About page template to create a page that contains many blocks.
2. I can confirm that when I long pressed on the block at the bottom of the page I was given an option to move this block to the top. I can also confirm that the block was moved to the top when this option was triggered.
3. I then utilized this very block to test the movement to the bottom. After long pressing the block mover I saw the “Move to bottom” option. When I pressed it the block was then moved to the bottom of the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the block mover behavior and the font size fix are working and I haven't noticed any other issues. LGTM 🚢
Description
This PR incorporates the 1.44.1 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#3006
Release Submission Checklist
RELEASE-NOTES.txt
if necessary.