Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal Layout Picker] Disable Page Template picker if MLP is enabled #2494

Merged
merged 3 commits into from
Jul 24, 2020

Conversation

antonis
Copy link

@antonis antonis commented Jul 20, 2020

Fixes: #2419

Related PRs:

Description

Adds a capability to hide the editor layout picker when the Modal Layout Picker(MLP) is enabled.
For detailed description of this PR please check wordpress-mobile/WordPress-Android#12482

Notes

This has been updated with the Consolidation of the Gutenberg initialProps handling

How has this been tested?

This feature can be tested by using the build from wordpress-mobile/WordPress-Android#12482

Screenshots

MLP Enabled MLP Disabled
device-2020-07-22-180349 device-2020-07-22-175155

Types of changes

New feature

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to [RELEASE-NOTES.txt](RELEASE-NOTES.txt) if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 20, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@antonis antonis changed the title Disable Page Template picker if Modal Layout Picker is enabled [Modal Layout Picker] Disable Page Template picker if MLP is enabled Jul 20, 2020
@antonis antonis added [OS] Android [Type] Enhancement Improves a current area of the editor labels Jul 22, 2020
@antonis antonis self-assigned this Jul 22, 2020
@antonis antonis requested a review from chipsnyder July 22, 2020 15:16
@antonis antonis marked this pull request as ready for review July 22, 2020 15:16
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonis antonis merged commit ecccd3d into develop Jul 24, 2020
@antonis antonis deleted the issue/2419-MLPContainerAndroid branch July 24, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] Android [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants