Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal Layout Picker] Create Modal window for Modal Layout Picker #2419

Closed
Assignees
Labels
Page Templates [Type] Enhancement Improves a current area of the editor

Comments

@chipsnyder
Copy link
Contributor

chipsnyder commented Jun 22, 2020

Is your feature request related to a problem? Please describe.

This task is part of the effort to rework the Starter Page Template Picker for new pages. This part of the initiative will focus on creating the base modal for the new Modal Layout Picker. Other tasks will then work off of the modal created in this task. It will also handle the feature flags to set up the build environments to enable the development and building of the new modal.

The goal will be to create a UI that looks something like:

iOS Android
iOS-Container Android-Container

Goals - Modal Container

  • When creating a new page, a modal should display with the following items:
    • Title
    • Subtitle
    • "Create Blank Page" Button
    • A button for dismissing the modal.
    • These items should be styled for Light and Dark interfaces.
  • Selecting the "Create Blank Page" button should create a new blank page.
  • Selecting the "X" (iOS) or Up button (Android) should dismiss the modal.
    • Android should validate the back button works as expected for dismissing the modal.
  • Swiping down on the modal should dismiss the modal.

Goals - Feature Flag

  • Selecting the Create page should only show this new modal when running:
    • iOS build configurations: localDevelopment and a8cBranchTest.
    • Android build configurations: vanilla and jalapeno.
  • Opening the editor should not show the existing STP picker if the modal has been shown
    • We can pass the feature flag to RN as part of capabilities (iOS, Android)
    • The key to pass as part of the capabilities should be modalLayoutPicker. true would mean the app supports modal layout picker
  • Opening the editor should show the existing STP picker if the modal has not been shown

Additional context

  • Creating a new page can happen from:
    • The FAB button on the bottom right of the site's home screen
    • The ➕ on the top right on the "Pages" screen in iOS or the FAB button on the "Pages" screen in Android
Blueprint Flow - iOS
Blueprint Flow - Android
@chipsnyder chipsnyder self-assigned this Jun 22, 2020
@chipsnyder
Copy link
Contributor Author

Reopening as Automation closed this before all tasks were done

@chipsnyder chipsnyder reopened this Aug 3, 2020
@antonis antonis closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment