Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported fallback remove dev only flag #2457

Merged
merged 13 commits into from
Jul 2, 2020
Merged

Unsupported fallback remove dev only flag #2457

merged 13 commits into from
Jul 2, 2020

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Jun 30, 2020 •
edited
Loading

Addresses #2358

To test: See WordPress/gutenberg#23592

PR submission checklist:

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 30, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@guarani guarani mentioned this pull request Jun 30, 2020
Open
26 tasks
@guarani guarani requested review from etoledom and marecar3 June 30, 2020 20:41
This was referenced Jun 30, 2020
Merged
Merged
Merged
@guarani guarani marked this pull request as ready for review July 1, 2020 01:48
@guarani guarani added this to the 1.32 milestone Jul 1, 2020
@guarani guarani self-assigned this Jul 1, 2020
@guarani guarani added [OS] Android [OS] iOS [Type] Enhancement Improves a current area of the editor labels Jul 1, 2020
@etoledom etoledom force-pushed the unsupported-fallback-remove-dev-only-flag branch from 1be2a9a to 03d1bfa Compare July 1, 2020 14:47
@etoledom etoledom force-pushed the unsupported-fallback-remove-dev-only-flag branch from 03d1bfa to e49ea3a Compare July 1, 2020 14:57
etoledom
etoledom approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/WordPress-Android#12331 (review) and wordpress-mobile/WordPress-iOS#14403 (review)

@guarani
Copy link
Contributor Author

guarani commented Jul 2, 2020 •
edited
Loading

After approval, I updated the Gutenberg submodule ref to include this PR — as well as any other changes on the master branch. This enabled the Unsupported Block editor on both the Gutenberg demo app as well as the Gutenberg for WP Apps demo app found in this repo.
I smoke tested the demo app on both platforms and the Unsupported Block editor is working correctly ✅.

@guarani guarani requested a review from etoledom July 2, 2020 01:04
etoledom
etoledom approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last update working great in both iOS and Android ✅

@etoledom etoledom merged commit b435ab2 into develop Jul 2, 2020
@etoledom etoledom deleted the unsupported-fallback-remove-dev-only-flag branch July 2, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees

@guarani guarani

Labels
[OS] Android [OS] iOS [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@guarani @etoledom @marecar3