Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported block editor is on all mobile builds #23592

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Unsupported block editor is on all mobile builds #23592

merged 3 commits into from
Jul 1, 2020

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Jun 30, 2020 •
edited
Loading

Description

Previously, mobile's unsupported block editor was only available on development builds. It is now ready to be made available on all builds, so this PR removes that restriction.

Related:

How has this been tested?

  1. Download the test build for iOS: Enable editing of unsupported blocks wordpress-mobile/WordPress-iOS#14403 (comment)

  2. Perform the test cases for the Unsupported Block Editor from Add test case for unsupported block editor wordpress-mobile/test-cases#39

    • TC001: New edits are persisted
    • TC002: Discarded edits are not persisted
    • TC003: WP.com Business (Atomic) sites are supported
    • TC004: Self-hosted sites are supported

  3. Repeat steps 1 and 2 for the test build for Android: Enable editing of unsupported blocks wordpress-mobile/WordPress-Android#12331 (comment)

Screenshots

Note: the black navigation bar title on the iOS gif below looks like a bug but not part of this PR — I see it on the v15.2 build of WPiOS and have reported it here.

iOS (light mode) Android (dark mode)

Types of changes

This code introduces a new feature: the ability for users to edit in a web-view blocks that are not yet supported on mobile

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@guarani guarani mentioned this pull request Jun 30, 2020
Merged
2 tasks
@github-actions
Copy link

github-actions bot commented Jun 30, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.62 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.42 kB 0 B
build/block-directory/style-rtl.css 941 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 109 kB 0 B
build/block-editor/style-rtl.css 10.7 kB 0 B
build/block-editor/style.css 10.7 kB 0 B
build/block-library/editor-rtl.css 7.44 kB 0 B
build/block-library/editor.css 7.44 kB 0 B
build/block-library/index.js 129 kB 0 B
build/block-library/style-rtl.css 8.04 kB 0 B
build/block-library/style.css 8.05 kB 0 B
build/block-library/theme-rtl.css 730 B 0 B
build/block-library/theme.css 732 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.2 kB 0 B
build/components/index.js 198 kB 0 B
build/components/style-rtl.css 15.9 kB 0 B
build/components/style.css 15.9 kB 0 B
build/compose/index.js 9.65 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.47 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.19 kB 0 B
build/edit-navigation/index.js 9.88 kB 0 B
build/edit-navigation/style-rtl.css 1.02 kB 0 B
build/edit-navigation/style.css 1.02 kB 0 B
build/edit-post/index.js 304 kB 0 B
build/edit-post/style-rtl.css 5.51 kB 0 B
build/edit-post/style.css 5.51 kB 0 B
build/edit-site/index.js 16.6 kB 0 B
build/edit-site/style-rtl.css 3 kB 0 B
build/edit-site/style.css 3 kB 0 B
build/edit-widgets/index.js 9.32 kB 0 B
build/edit-widgets/style-rtl.css 2.42 kB 0 B
build/edit-widgets/style.css 2.42 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 44.9 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.86 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.56 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 450 B 0 B
build/list-reusable-blocks/style.css 451 B 0 B
build/media-utils/index.js 5.29 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 788 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 14 kB 0 B
build/server-side-render/index.js 2.67 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@guarani guarani added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Jun 30, 2020
@guarani guarani requested review from etoledom and marecar3 June 30, 2020 20:41
This was referenced Jun 30, 2020
Merged
Merged
@guarani guarani marked this pull request as ready for review July 1, 2020 01:40
@guarani guarani self-assigned this Jul 1, 2020
@etoledom etoledom force-pushed the rnmobile/unsupported-fallback-remove-dev-only-flag branch from 00a2cd1 to d7b7b11 Compare July 1, 2020 14:32
@etoledom etoledom force-pushed the rnmobile/unsupported-fallback-remove-dev-only-flag branch from d7b7b11 to 1c66a2e Compare July 1, 2020 14:39
@etoledom
Copy link
Contributor

etoledom commented Jul 1, 2020

Updated the PR making it possible to enable-disable this feature (Unsupported Block Editor) from the client apps.
This will let us choose when to show or hide the Gutenberg-web option.

marecar3
marecar3 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guarani guarani merged commit d41c9d4 into master Jul 1, 2020
@guarani guarani deleted the rnmobile/unsupported-fallback-remove-dev-only-flag branch July 1, 2020 21:52
@github-actions github-actions bot added this to the Gutenberg 8.5 milestone Jul 1, 2020
@cameronvoell cameronvoell mentioned this pull request Jul 28, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@etoledom etoledom Awaiting requested review from etoledom

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@guarani guarani

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 8.5
Development

Successfully merging this pull request may close these issues.
3 participants
@guarani @etoledom @marecar3