Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress block: Privacy setting remains available even when it's not usable #5640

Open
SiobhyB opened this issue Apr 6, 2023 · 1 comment
Labels

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Apr 6, 2023

Describe the bug

After adding a VideoPress public video (e.g. https://videopress.com/v/OcobLTqC), it's possible to access the Privacy and Rating panel under the VideoPress block's settings, even though it's not possible to actually change the block's privacy.

It is unlikely that many users will go through this flow, but would still be ideal if we could either improve the error message or hide the privacy setting when it can't be used.

This is also an issue on web, issue here: Automattic/jetpack#29964

To Reproduce

Steps to reproduce the behavior:

  1. Go through the steps to add a VideoPress block to a post.
  2. Select the option to Insert from URL.
  3. Add a VideoPress public video (e.g. https://videopress.com/v/OcobLTqC).
  4. Navigate to the Privacy and Rating panel in the block's settings.
  5. Change the block's privacy from public to private and then save the post.

Expected behavior

It's not actually possible to change the privacy of the public video. As such, I would ideally expect to not even have access to the Privacy and Rating panel. If the panel has to remain in place, I would at least expect an informative error message to guide me on why it's not possible to tweak the video's privacy.

@fluiddot
Copy link
Contributor

I noticed that also Details settings (i.e. Title and Description) can't be edited on a VideoPress public video. In fact, doing this in the web version produces an error and locks the block settings.

web-update-details-settings.mp4

dcalhoun added a commit to wordpress-mobile/test-cases that referenced this issue Jul 30, 2024
The privacy settings are unsupported within the native mobile editor.

wordpress-mobile/gutenberg-mobile#5640
dcalhoun added a commit to wordpress-mobile/test-cases that referenced this issue Jul 30, 2024
The privacy settings are unsupported within the native mobile editor.

wordpress-mobile/gutenberg-mobile#5640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants