-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal Layout Picker] Add support for Self-Hosted sites #2455
Comments
@iamthomasbishop @enejb cc @antonis |
Actually I should continue to investigate this. Testing the current picker it appears that the existing picker isn't translated either: |
The endpoint for fetching the block layouts is configured to support localization by including the query parameter To support that without duplicating the data natively, I think we would violate the goal of "there shouldn't be an excessive amount of time spent on that aspect." So it seems like we'd want to create the meta-data in the iOS and Android native code and revisit a mechanism to share the data later. |
This was closed by mistake from a partial PR merge |
Is your feature request related to a problem? Please describe.
This task is part of the effort to rework the Starter Page Template Picker for new pages. On a self-hosted site as a user, I should be able to use the new layout picker utilizing the layouts that are currently provided in the existing STP picker.
Goals
+ The format of the existing layouts should be modified to match the scheme as provided by /wpcom/v2/sites/{site}/block-layouts and copied to a place that is accessible by the apps.+ Ideally these will be moved to a place that can be shared by both iOS and Android then served up through their respective Gutenberg Mobile libraries. However, there shouldn't be an excessive amount of time spent on that aspect. For the first version, we can duplicate the data and improve the reusability later if needed.+ The existing SPT should still work when this feature is disabled.+ This data can be used as the static data used to build the UI in [Modal Layout Picker] Create Layout Picker sections and thumbnail UI using static data #2436, and [Modal Layout Picker] Create Layout Picker category bar UI using static data #2437https://public-api.wordpress.com/wpcom/v2/common-block-layouts
Additional context
Blueprint Flow - iOS
Blueprint Flow - Android
The text was updated successfully, but these errors were encountered: