Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Endpoint containing the current with starter page layouts #2413

Closed
enejb opened this issue Jun 22, 2020 · 5 comments
Closed

Add API Endpoint containing the current with starter page layouts #2413

enejb opened this issue Jun 22, 2020 · 5 comments
Assignees

Comments

@enejb
Copy link
Contributor

enejb commented Jun 22, 2020

Currently we ship Gutenberg Mobile with a set of Starter Page Layouts.

Found in https://github.com/WordPress/gutenberg/tree/8fc02a040d4f453e5a57d1e359cf84d1c319bfa6/packages/block-editor/src/components/page-template-picker/templates

We want to introduce many more layouts and want the that list to grow.

Lets create a new api endpoint that contains the current layouts that we have.

The layouts that we should offer are
About, Contact, Portfolio, Service, Team

@enejb enejb self-assigned this Jun 22, 2020
@enejb enejb changed the title Add API Endpoint containing the current with block-layouts Add API Endpoint containing the current with started page layouts Jun 22, 2020
@pinarol pinarol changed the title Add API Endpoint containing the current with started page layouts Add API Endpoint containing the current with starter page layouts Jun 22, 2020
@pinarol
Copy link
Contributor

pinarol commented Jun 22, 2020

@enejb Can you clarify below items to finalize the 'definition of done' for this task:

  • Are we copying all the existing mobile layouts to backend in this task?
  • What's the process of copying? Manual or automated?
  • What should the backend copy look like?
  • What's the plan for translating the strings for this particular task?
  • Can we expect that the request/response of the endpoint will be detected inside this task?

Thanks!

@pinarol
Copy link
Contributor

pinarol commented Jun 22, 2020

Another thing we should make sure is using the most up to date versions of the templates, currently they are in the repo: https://github.com/WordPress/gutenberg/tree/master/packages/block-editor/src/components/page-template-picker/templates

@enejb
Copy link
Contributor Author

enejb commented Jun 23, 2020

Done when

  1. All existing layouts are copied to back-end.
  2. Translation of layouts
  3. Partial translations (part by part) (every sentence will be translated se).
  4. Request/Response model will be approved by @chipsnyder.
  5. Thumbnails should be in the correct size according to the device's scale.
  6. In production.

@enejb
Copy link
Contributor Author

enejb commented Jun 24, 2020

I am marking this as done.

Since I deployed D45124-code

The request/response model was approved by @chipsnyder.
We will make any changes as required in future PRs.

And the endpoint is now available in production.
See:
Screen Shot 2020-06-24 at 4 42 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@enejb @pinarol and others