[Mobile] Generate static data to be used to develop Modal Layout picker #24027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odal Layour Picker
chipsnyder
added
the
Mobile App - i.e. Android or iOS
chipsnyder
changed the title
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
pinarol
reviewed
Jul 24, 2020
| public let slug: String | ||
| public let title: String | ||
| public let preview: String | ||
| public let categories: [GutenbergLayoutCategory] |
There was a problem hiding this comment.
Not sure why this is an array 🤔 Are we aware of any use case where a layout appears under different categories?
There was a problem hiding this comment.
I'm not sure if we would expect multiple categories for a layout or not. My goal with the structs GutenbergPageLayouts, GutenbergLayout, and GutenbergLayoutCategory was to mirror the syntax of the response that comes from the API to make parsing those a bit easier and to prevent having one struct for the API and another for the UI.
Otherwise we'll need to search in GutenbergLayout instances to get layouts for a specific category.
To prevent having to do this I added groupedLayouts to so that we only need to organize the layouts into categories once. Since it's a small n I figured there wouldn't be a noticeable performance hit.
Sample API Response
{
"layouts": [
{
"slug": "about-2",
"title": "About",
"content": "...",
"categories": [
{
"slug": "about",
"title": "About",
"description": "About pages",
"emoji": "👋"
}
],
"preview": "https://headstartdata.files.wordpress.com/2020/01/about-2.png?w=200&zoom=1"
},
...
],
"categories": [
{
"slug": "about",
"title": "About",
"description": "About pages",
"emoji": "👋"
}
...
]
}
There was a problem hiding this comment.
mirror the syntax of the response that comes from the API
OK thanks, LGTM then!
| public let slug: String | ||
| public let title: String | ||
| public let description: String | ||
| public let emoji: String |
There was a problem hiding this comment.
Just thinking out loud, would it not be simpler if we had array of GutenbergLayout here instead? Otherwise we'll need to search in GutenbergLayout instances to get layouts for a specific category.
pinarol
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes: wordpress-mobile/gutenberg-mobile#2455
Description
Exposes static data for creating the modal layout picker for Gutenberg Mobile. The goal of placing it in the Gutenberg library was in hopes of creating a mechanism down the road where the layout can be defined once and then used to generate a file for iOS and Android.
The Preview images used below were picked to align with what would be returned by sites that use WPCOM endpoints.
How has this been tested?
This is not independently testable at this point but will be testable in WPiOS as the layout picker is developed.
Screenshots
Types of changes
New feature
Checklist: