Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Remove code associated to Story block #22758

Merged
merged 8 commits into from
Mar 5, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 4, 2024

Related PRs:

This PR is a follow-up of #22449, it removes the code associated with the Story block.

Warning

There are still several references to the Story post/block functionality across the code base. Eventually, wordpress-mobile/WordPress-Android#20005, we should plan to remove all associated code.

To test:

Since the Story block was disabled some time ago, we don't expect that these changes will have an impact on the editor. Nevertheless, we could focus on smoke testing the editor.

Regression Notes

  1. Potential unintended areas of impact

Editor.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing.

  1. What automated tests I added (or what prevented me from doing so)

None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 4, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22758-9d5d210
Version24.4
Bundle IDorg.wordpress.alpha
Commit9d5d210
App Center BuildWPiOS - One-Offs #9068
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 4, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22758-9d5d210
Version24.4
Bundle IDcom.jetpack.alpha
Commit9d5d210
App Center Buildjetpack-installable-builds #8111
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@fluiddot fluiddot marked this pull request as ready for review March 4, 2024 13:14
@SiobhyB SiobhyB self-requested a review March 4, 2024 17:13
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I smoke tested the editor and verified all works as expected with all the linked PRs checked out. The removed code also looks correct to me. 🚀 Thanks for working on this @fluiddot!

@fluiddot fluiddot added this to the 24.5 milestone Mar 4, 2024
@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 4, 2024

I've added the Do Not Merge label to prevent merging the PR until version 24.4 code freeze is finalized.

@fluiddot fluiddot merged commit ed63c3b into trunk Mar 5, 2024
25 of 26 checks passed
@fluiddot fluiddot deleted the gutenberg/remove/story-block branch March 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants