Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Disable Story block #22449

Merged
merged 7 commits into from
Jan 26, 2024
Merged

[Gutenberg] Disable Story block #22449

merged 7 commits into from
Jan 26, 2024

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 23, 2024

Related PRs:

Internal ref: pcdRpT-4Vq-p2

This PR aims to disable the story block.

To test

Story block can't be inserted

  1. Create a post.
  2. Tap on ➕ button.
  3. Scroll the block list and observe that the Story block is not displayed.
  4. Tpa on the Paragraph block.
  5. Type /story and observe that the Story block option is not displayed.

Story block is displayed as unsupported

  1. In the browser, create a post and insert a Story block.
  2. Go to the app and open the same post.
  3. Observe that the Story block is displayed as unsupported.
  4. Tap on the block and observe that it can still be edited via UBE (Unsupported Block Editor).

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested manually the editor.

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label Jan 23, 2024
@fluiddot fluiddot added this to the 24.2 milestone Jan 23, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 23, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22449-cfafeb9
Version24.1
Bundle IDorg.wordpress.alpha
Commitcfafeb9
App Center BuildWPiOS - One-Offs #8564
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 23, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22449-cfafeb9
Version24.1
Bundle IDcom.jetpack.alpha
Commitcfafeb9
App Center Buildjetpack-installable-builds #7591
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@fluiddot fluiddot changed the title [Gutenberg] Disable Story block [TEST] [Gutenberg] Disable Story block Jan 25, 2024
@dcalhoun dcalhoun self-requested a review January 25, 2024 16:07
@fluiddot fluiddot changed the title [TEST] [Gutenberg] Disable Story block [Gutenberg] Disable Story block Jan 25, 2024
@fluiddot fluiddot marked this pull request as ready for review January 25, 2024 16:14
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/gutenberg-mobile#6568 (review).

Should add a release note in this PR or manage that elsewhere?

@fluiddot
Copy link
Contributor Author

Should add a release note in this PR or manage that elsewhere?

Since this change will be incorporated into the beta version 24.1. I'll do that in the release PR.

@fluiddot fluiddot enabled auto-merge January 26, 2024 17:05
@fluiddot fluiddot merged commit d80d73b into trunk Jan 26, 2024
20 of 22 checks passed
@fluiddot fluiddot deleted the gutenberg/disable-story-block branch January 26, 2024 23:22
@kean kean mentioned this pull request Jun 24, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants