-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Gutenberg - Slash inserter #16064
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
c7c50b2
to
1b38f9b
Compare
EDIT: I just realized I accidentally posted this to the WPiOS PR, not the main Gutenberg one — too many open tabs! 🤦 😆 . I can re-post over there if you'd like. @geriux @mkevins I gave the new build a spin on both platforms and it's looking and feeling great! The color refinements look solid. thanks for taking care of that 👍 I noticed one blocker on Android that I'd like to fix (if possible) before we ship this, and then I have two separate proposals which we discussed in Slack on Wed/Thu, but aren't considered blockers if we are anxious to ship this. Issue: Blocking toolbar on AndroidI just noticed on Android that the toolbar can sometimes cover the selected block if the selected block is roughly vertically centered in the viewport (video). Is there any way we can adjust the Y-position of the block/canvas a bit more to ensure that the input remains visible? Note: this is on Android — iOS seems to add an additional bit of margin so I'm not seeing the same issue, as you can see in this video) ProposalsAgain, these are not considered blockers preventing us from shipping what we have here, but I wanted to propose a couple of small refinements that we could make moving forward. We can split into separate issues if necessary. Proposal: new italics iconI have often felt the "italics" icon that we are using (from the WP icon set aka "G2") was a little confusing, but it hasn't caused any real conflicts until now, because the icon tends to look like a "slash", which is obviously a potential issue considering the "/" character of the placeholder/writing prompt is close enough in proximity to the "italic" icon in the block toolbar. I found at least one issue upon a quick GitHub search, and think it'd be worth proposing some updates to the icon in core, but in the meantime I propose that we use a custom icon on mobile. A simple extension of the current Proposal: refined writing promptNow that I'm seeing the prompt in context, I realized we have an opportunity here (and space) to also hint at the standard (+) inserter button. This should assist in discovery (which is relevant to one of our findings from recent usability tests, wherein users needed a little nudge towards the button to discover it). Here are 2 options — the first very straight forward and the second a little less straight forward but arguably more impactful:
Let me know if you have any questions or concerns. I think once we're able to sort out the Android scroll position issue, let's go ahead and ship this unless you feel the proposals are worth rolling into the initial release. Thanks again for all of y'all's great work on this! |
01ce267
to
7d60247
Compare
To generate testing builds
Gutenberg Mobile PR
-> wordpress-mobile/gutenberg-mobile#3250Gutenberg PR
-> WordPress/gutenberg#29772WordsPress Android PR
-> wordpress-mobile/WordPress-Android#14245Fixes #
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.