Mobile - Slash inserter #29772
Merged
Mobile - Slash inserter #29772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the block completer
geriux
added
[Status] In Progress
|
Size Change: +10 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
2 tasks
enejb
reviewed
Mar 12, 2021
|
I tested this briefly via wordpress-mobile/WordPress-iOS#16064 |
@geriux I just took another look at the test build on iOS and iPad OS to make sure, and it's looking good. Let's 🚢 it! 👏 |
|
@geriux Sounds fine. Worth nothing that in the future we'd like to get rid of this component and create something more integrated with rich text. As long as we're not exposing new APIs here I'm fine with it. |
ellatrix
reviewed
May 5, 2021
added 4 commits
May 12, 2021 09:15
# Conflicts: # packages/react-native-editor/CHANGELOG.md
This reverts commit c251037.
enejb
reviewed
May 18, 2021
packages/components/src/autocomplete/autocompleter-ui.native.js
Outdated
Show resolved
Hide resolved
enejb
reviewed
May 18, 2021
enejb
reviewed
May 18, 2021
packages/react-native-editor/__device-tests__/[email protected]
Outdated
Show resolved
Hide resolved
|
Nice work team! I tested this and it works really well. One thing I noticed is that if you mistype a block the autocomplete bar disappears right away (No animation). This is a really minor thing. I left a couple of minor notes and a few questions. (Feel free to ignore them :) ) I am happy to test this again after the rebase and give it the final 👍 |
enejb
reviewed
May 18, 2021
| @import "./style.native.scss"; | ||
|
|
||
| .components-autocomplete { | ||
| width: 100%; |
There was a problem hiding this comment.
width: 100%;
Is this needed?
# Conflicts: # packages/components/src/autocomplete/index.js # packages/react-native-editor/CHANGELOG.md
enejb
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#2620
Description
This PR adds the
/(slash) key shortcut to add a block on mobile.Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#3250WordPress iOS PR-> wordpress-mobile/WordPress-iOS#16064WordsPress Android PR-> wordpress-mobile/WordPress-Android#14245Pending issues:
$gray-light(light mode) and$neutral-dim-dark(dark mode).Hide feature behind a feature flag for DEVonce this PR is approved it'll ship to production so no DEV flag needed.React.createElement: type is invalid -- expected a string (for built-in components)How has this been tested?
Paragraphblock/character following by any block nameScreenshots
Types of changes
New feature
Checklist: