Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Add Cover block media settings #15120

Closed
wants to merge 4 commits into from
Closed

[Gutenberg] Add Cover block media settings #15120

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 18, 2020 •
edited by dcalhoun
Loading

Fixes wordpress-mobile/gutenberg-mobile#1741

To test: Test plan in Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 18, 2020 •
edited
Loading

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

This was referenced Oct 18, 2020
Closed
Merged
@ghost ghost marked this pull request as ready for review October 19, 2020 02:17
@geriux geriux self-requested a review October 19, 2020 10:07
@geriux geriux added the Gutenberg Editing and display of Gutenberg blocks. label Oct 19, 2020
@ghost ghost mentioned this pull request Oct 21, 2020
Closed
2 tasks
@ghost ghost changed the title Gutenberg - Focal Point Picker Tooltip Gutenberg - Add Cover block media settings Oct 21, 2020
@dcalhoun dcalhoun force-pushed the gutenberg/media-settings branch from c236432 to 23eeea3 Compare January 12, 2021 17:35
@dcalhoun dcalhoun force-pushed the gutenberg/media-settings branch from 23eeea3 to ab08041 Compare January 13, 2021 20:23
@dcalhoun dcalhoun changed the title Gutenberg - Add Cover block media settings [Gutenberg] Add Cover block media settings Jan 13, 2021
@dcalhoun dcalhoun mentioned this pull request Jan 19, 2021
Merged
2 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 19, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@dcalhoun
Copy link
Member

Superseded by #15665.

@dcalhoun dcalhoun closed this Jan 19, 2021
@dcalhoun dcalhoun deleted the gutenberg/media-settings branch April 15, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux Awaiting requested review from geriux

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cover block: Add media settings(fixed background and focal point picker)
2 participants
@dcalhoun @geriux