-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cover block media settings #3028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
force-pushed
the
add/cover-block-media-settings
branch
from
January 19, 2021 17:35
7b212f3
to
08c959a
Compare
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
ghost
mentioned this pull request
Jan 19, 2021
6 tasks
This was referenced Jan 19, 2021
dcalhoun
force-pushed
the
add/cover-block-media-settings
branch
from
January 19, 2021 22:17
2533475
to
b8d5204
Compare
dcalhoun
force-pushed
the
add/cover-block-media-settings
branch
from
January 29, 2021 18:10
be73ce5
to
10fea9e
Compare
dcalhoun
force-pushed
the
add/cover-block-media-settings
branch
from
February 3, 2021 22:07
10fea9e
to
afa4d71
Compare
dcalhoun
force-pushed
the
add/cover-block-media-settings
branch
from
February 11, 2021 12:53
afa4d71
to
3f37939
Compare
geriux
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Approved via WordPress/gutenberg#25810 (review)
dcalhoun
force-pushed
the
add/cover-block-media-settings
branch
from
February 15, 2021 16:36
8b81134
to
513b070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1741
To test: Test plan in Gutenberg PR description.
PR submission checklist: