-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gutenberg-mobile release 1.35.0 #14665
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Sanity testingDarkMode-2
Group-2
Spacer-2
Buttons-4
Button-5
Button-6
Editor Theme-2 ❌ Custom Gradients - Check that custom gradients load in the editor - steps Same issues as the previous release. Color Settings-2 |
Hey @chipsnyder 👋 I had the same issues from the previous release related to the custom gradients. I guess it is still the jetpack sync issue right? |
👍 Yup, @enejb is looking into it still. Hopefully, we can get it resolved in the next Jetpack release. |
Sounds good! Thanks! |
We are all good on the sanity tests ✅ The failed ones of the Color settings are for a known issue that we are working on but it's not a blocker. The failed test with the Spacer block is not a blocker either, I think we need to update that test case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fails with Podfile.lock was changed by 'pod install'
error but I didn't get any changes locally running rm -rf Pods && bundle exec pod install --repo-update
.
Could be something to do with RNCMaskedView
.
Can't approve as I'm the author but
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came to same conclusions as @ceyhun
CI fails with
Podfile.lock was changed by 'pod install'
error but I didn't get any changes locally runningrm -rf Pods && bundle exec pod install --repo-update
.
Could be something to do withRNCMaskedView
.
Can't approve as I'm the author but
LGTM
d3a83d1
to
bf2afe7
Compare
Though
So we'll merge for now, while continuing to investigate why this change d0781ad is not produced consistently for all developers |
Description
This PR incorporates the 1.35.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#2557
Release Submission Checklist
RELEASE-NOTES.txt
if necessary.