Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release 1.35.0 #14665

Merged
merged 7 commits into from
Aug 20, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Aug 18, 2020

Description

This PR incorporates the 1.35.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#2557

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ceyhun ceyhun added the Gutenberg Editing and display of Gutenberg blocks. label Aug 18, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 18, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 18, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@geriux
Copy link
Contributor

geriux commented Aug 18, 2020

Sanity testing

DarkMode-2

  • Spacer block - Dark mode - steps
  • Buttons block - Dark mode - steps
  • Group - Dark mode - steps
  • Columns - Dark mode - steps

Group-2

  • Group - Navigation up button works as expected - steps
  • Group - Navigation down works according to parent-first approach - steps
  • Group - Cross navigation between blocks works as expected - steps
  • Group - Ungroup button works as expected - steps
  • Group - Check if in DarkMode all components gets proper colors - steps
  • Group - Check if nested Placeholder block can be replaced - steps

Spacer-2

  • Spacer block - Settings: Available height range is correct - steps
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps The editor is not allowing to change the height of the spacer from the HTML editor. Happens on web too.
    Edit 2: After double checking this is working correctly.
  • Spacer block - Spacer in horizontal layout works as expected - steps

Buttons-4

  • Buttons block - Render custom text color - steps
  • Buttons block - Render custom background color - steps
  • Buttons block - Render gradient background color - steps
  • Buttons block - Check if selection / caret color matches font color - steps
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps

Button-5

  • Buttons block - Edit text styles - steps
  • Buttons block - Render theme colors - steps
  • Buttons block - Settings: Change Button border radius - steps

Button-6

  • Buttons block - Settings: Open in new tab - steps
  • Buttons block - Settings: Link rel - steps
  • Buttons block - Settings: Link URL - steps
  • Buttons block - Settings: Remove link - steps
  • Buttons block - Settings: Synchronize with button options - steps

Editor Theme-2

❌ Custom Gradients - Check that custom gradients load in the editor - steps
❌ Offline Support - steps

Same issues as the previous release.

Color Settings-2

  • Pressing color swatch - steps
  • Customize gradient color - steps
  • Custom color picker - steps

@geriux
Copy link
Contributor

geriux commented Aug 18, 2020

Hey @chipsnyder 👋 I had the same issues from the previous release related to the custom gradients. I guess it is still the jetpack sync issue right?

@chipsnyder
Copy link
Contributor

I guess it is still the jetpack sync issue right?

👍 Yup, @enejb is looking into it still. Hopefully, we can get it resolved in the next Jetpack release.

@cameronvoell cameronvoell self-requested a review August 19, 2020 01:02
@cameronvoell cameronvoell marked this pull request as ready for review August 19, 2020 01:03
@cameronvoell cameronvoell added this to the 15.6 milestone Aug 19, 2020
@geriux
Copy link
Contributor

geriux commented Aug 19, 2020

I guess it is still the jetpack sync issue right?

👍 Yup, @enejb is looking into it still. Hopefully, we can get it resolved in the next Jetpack release.

Sounds good! Thanks!

@geriux
Copy link
Contributor

geriux commented Aug 19, 2020

We are all good on the sanity tests ✅ The failed ones of the Color settings are for a known issue that we are working on but it's not a blocker. The failed test with the Spacer block is not a blocker either, I think we need to update that test case.

Copy link
Contributor Author

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails with Podfile.lock was changed by 'pod install' error but I didn't get any changes locally running rm -rf Pods && bundle exec pod install --repo-update.
Could be something to do with RNCMaskedView.
Can't approve as I'm the author but :shipit:

Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Came to same conclusions as @ceyhun

CI fails with Podfile.lock was changed by 'pod install' error but I didn't get any changes locally running rm -rf Pods && bundle exec pod install --repo-update.
Could be something to do with RNCMaskedView.
Can't approve as I'm the author but :shipit:

LGTM :shipit:

@cameronvoell cameronvoell force-pushed the gutenberg/integrate_release_1.35.0 branch from d3a83d1 to bf2afe7 Compare August 20, 2020 16:28
@cameronvoell
Copy link
Contributor

Though rake dependencies does not seem to always agree with d0781ad, I was able to manually verify the checksum using:

cameronvoell$ pod ipc spec RNCMaskedView.podspec | openssl sha1
5a8ec07677aa885546a0d98da336457e2bea557f

So we'll merge for now, while continuing to investigate why this change d0781ad is not produced consistently for all developers

@cameronvoell cameronvoell merged commit e63ca62 into develop Aug 20, 2020
@cameronvoell cameronvoell deleted the gutenberg/integrate_release_1.35.0 branch August 25, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants