Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg release 1.34.0 #12588

Merged
merged 11 commits into from
Aug 8, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Aug 3, 2020

This PR incorporates the 1.34.0 release of gutenberg-mobile. For details about the changes included in this PR and testing instructions please see the related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2529

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 3, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ceyhun ceyhun added Gutenberg Editing and display of Gutenberg blocks. gutenberg-mobile labels Aug 3, 2020
@ceyhun ceyhun added this to the 15.5 milestone Aug 3, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 3, 2020

You can test the changes on this Pull Request by downloading the APK here.

@mchowning mchowning marked this pull request as ready for review August 4, 2020 20:28
@dratwas
Copy link
Contributor

dratwas commented Aug 5, 2020

DarkMode-2

  • Spacer block - Dark mode
  • Buttons block - Dark mode
  • Group - Dark mode
  • Columns - Dark mode

Group-2

  • Group - Navigation up button works as expected
  • Group - Navigation down works according to parent-first approach
  • Group - Cross navigation between blocks works as expected
  • Group - Ungroup button works as expected
  • Group - Check if in DarkMode all components gets proper colors
  • Group - Check if nested Placeholder block can be replaced

Spacer-2

  • Spacer block - Settings: Available height range is correct
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px
  • Spacer block - Spacer in horizontal layout works as expected

Buttons-4

  • Buttons block - Render custom text color
  • Buttons block - Render custom background color
  • Buttons block - Render gradient background color
  • Buttons block - Check if selection / caret color matches font color
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview

Button-5

  • Buttons block - Edit text styles
  • Buttons block - Render theme colors
  • Buttons block - Settings: Change Button border radius

Button-7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options
  • Buttons block - Toolbar link button is active when Button has link

Editor Theme - 2
❌ Custom Gradients - Check that custom gradients load in the editor
❌ Offline Support

'm not sure if I do everything correct but it doesn't work for me. Steps that i did:

  • downloaded and installed the twentytwenty-copy theme.
  • set the Blue to Purple gradient as a button background (the only available)

Screenshot 2020-08-05 at 13 30 48

- Opened that post on mobile - The background color was not correct and there was not that gradient in the gradient list.

Screenshot 2020-08-05 at 13 30 48

Screenshot 2020-08-05 at 13 30 48

Color Settings - 2

  • Pressing color swatch
  • Customize gradient color
  • Custom color picker

@pinarol
Copy link
Contributor

pinarol commented Aug 5, 2020

@chipsnyder can you check if there's anything odd about Editor Theme failed cases reported above?

@chipsnyder
Copy link
Contributor

Tested the Editor Theme - 2 above using the this APK

I had no problems:

@dratwas If you open the editor a second time does the theme load? I wonder if the event for updating the theme was lost over the bridge loading.

cc @pinarol

@dratwas
Copy link
Contributor

dratwas commented Aug 6, 2020

@dratwas If you open the editor a second time does the theme load? I wonder if the event for updating the theme was lost over the bridge loading.

Hey, @chipsnyder I tried the same build on 2 different devices and have the same issue on both of them. The reopening of the editor doesn't help :( I can use this gradient only on the web and see just in preview (even on the web - it has default background in the visual editor). The same issue occurs on the emulator.

@chipsnyder
Copy link
Contributor

After a bit of research and discovery with @dratwas help, we tracked this down to an issue with a Jetpack sync. It seems like it's updating these values with the data from the previous theme instead of the new theme. So the API response has the values for theme change n-1 if n is the current theme.

@enejb is helping to investigate.

@cameronvoell cameronvoell requested a review from guarani August 7, 2020 22:18
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build 65485 and verified that the relevant user-facing changes are present:

Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cameronvoell cameronvoell merged commit d8506ba into develop Aug 8, 2020
@ceyhun ceyhun deleted the gutenberg/integrate_release_1.34.0 branch August 10, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants