-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gutenberg release 1.34.0 #12588
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
DarkMode-2
Group-2
Spacer-2
Buttons-4
Button-5
Button-7
Editor Theme - 2 'm not sure if I do everything correct but it doesn't work for me. Steps that i did:
Color Settings - 2
|
@chipsnyder can you check if there's anything odd about Editor Theme failed cases reported above? |
Hey, @chipsnyder I tried the same build on 2 different devices and have the same issue on both of them. The reopening of the editor doesn't help :( I can use this gradient only on the web and see just in preview (even on the web - it has default background in the visual editor). The same issue occurs on the emulator. |
After a bit of research and discovery with @dratwas help, we tracked this down to an issue with a Jetpack sync. It seems like it's updating these values with the data from the previous theme instead of the new theme. So the API response has the values for theme change n-1 if n is the current theme. @enejb is helping to investigate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested build 65485 and verified that the relevant user-facing changes are present:
- Cover block - Media editing: [Mobile] - Cover block - Media editing WordPress/gutenberg#23280
- Revert "[RNMobile] Fix jumping toolbar": Revert "[RNMobile] Fix jumping toolbar" WordPress/gutenberg#24388
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR incorporates the 1.34.0 release of gutenberg-mobile. For details about the changes included in this PR and testing instructions please see the related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2529
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.