Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update media permissions for Android 13 #126

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

irfano
Copy link
Member

@irfano irfano commented Mar 29, 2023

This PR removes WRITE_EXTERNAL_STORAGE for devices with API higher than 29.
WRITE_EXTERNAL_STORAGE is not required for SDK higher than 29.

This fixes the camera permission issue on wordpress-mobile/WordPress-Android#18183

WRITE_EXTERNAL_STORAGE is not required for SDK higher than 29.
@irfano irfano added the Android 13 Android 13 Migration label Mar 29, 2023
@irfano irfano requested a review from ravishanker March 29, 2023 00:36
Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ravishanker ravishanker merged commit 5011523 into trunk Mar 29, 2023
@ravishanker ravishanker deleted the update-storage-permission branch March 29, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 13 Android 13 Migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants