Android 13 media permissions #18183

irfano · 2023-03-27T22:06:11Z

This updates media permissions for Android 13 compatibility.

Granular media permissions
READ_EXTERNAL_STORAGE is used for accessing photos, videos, and audio files. After upgrading targetSdk to 33, we need to use specific permissions, READ_MEDIA_IMAGES, READ_MEDIA_VIDEO, and READ_MEDIA_AUDIO.

I've used granular permissions for >=API 33. READ_EXTERNAL_STORAGE is still used for older APIs. READ_MEDIA_IMAGES and READ_MEDIA_VIDEO are different permissions on the code, but they appear as single permission, "Photos and videos". So, I requested both READ_MEDIA_IMAGES and READ_MEDIA_VIDEO even though just photos are needed.
I've also updated [WRITE_EXTERNAL_STORAGE] (https://developer.android.com/reference/android/Manifest.permission#WRITE_EXTERNAL_STORAGE) usage, which has no effect for devices higher than API 29.
pdf files are not listed on the media picker on devices that use API 30 or newer. It's not introduced with API 33. Opened an issue.
Some strings were wrong. They're also updated in this PR. (Storage and Storage → Photos and videos)

before denied	after denied - all media	after denied - images	after denied - audio

To test:
Please perform all tests using a device with API 33 or higher and a device with an API version lower than 33.

Media Picker - Image - Choose from device

Launch the JP app.
Create a blog post.
Add an Image block.
Tap on the block and tap "Choose from device".
Allow permission and add an image.
Ensure the image is added without any issues.
Disable the permission from the system settings.
Repeat 1-6, but deny the permission this time. Ensure the message direct you to the system settings to allow the permission.
Enable the permission on system settings
Add an image and ensure it's added as expected.

Media Picker - Image - Other options

Repeat "Media Picker - Image - Choose from device", but this time, try selecting other options instead of "Choose from device".

Media Picker - Video
Repeat Media Picker - Image tests with the video.

Media Picker - Audio
Repeat Media Picker - Image tests with the audio.

Media Browser

Launch the JP app.
Ensure you have all types of files on your media browser. (image, video, audio, and a file such as pdf)
Navigate to "My Site → Media".
Ensure all files on your device are listed.
Tap an image.
On the media detail screen, tap the save button at top of the screen.
Ensure the file is downloaded to your device.
Repeat 1-7 for other types of files.

Story

Warning
Story feature can be tested once Automattic/stories-android#731 is ready.

Launch the JP app.
Tap the green floating button at the bottom of the screen.
Tap "Story post". If you see a popup, tap Create Post button to continue.
Allow permissions and ensure you can see your media on the device.
Select a media and post the story.
Create another post and take a photo this time.
Ensure you can post the story by taking a photo or video.
Put the app in the background.
Go to the system settings and disable the permissions.
Go back to the create story screen. Ensure denied permission message is shown.
To ensure it works as expected for all cases, try to allow and disable some permissions and test different variations (like allow audio, deny camera, deny images).

Regression Notes

Potential unintended areas of impact
All screens that need storage permission.
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested all cases manually.
What automated tests I added (or what prevented me from doing so)
Updated existing tests.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

WRITE_EXTERNAL_STORAGE is not required for SDK higher than 29.

For devices with API 33 and higher, we must request one or more of the granular media permissions instead of the READ_EXTERNAL_STORAGE permission.

…ptimization

wpmobilebot · 2023-03-27T22:23:02Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18183-8b50e67
	Commit	`8b50e67`
	Direct Download	`jetpack-prototype-build-pr18183-8b50e67.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-03-27T22:24:26Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr18183-8b50e67
	Commit	`8b50e67`
	Direct Download	`wordpress-prototype-build-pr18183-8b50e67.apk`

Note: Google Login is not supported on these builds.

ravishanker · 2023-03-28T06:22:45Z

👋 @irfano - Nice work! All the steps are working, except Take a Photo or Video is asking for Storage permission, and that leads to nowhere in system settings where it can be enabled! Looked through System Settings -> Apps and through Privacy -> Permissions Manager. Happening on both JP and WP.

fluiddot · 2023-03-28T17:28:44Z

👋 @irfano - Nice work! All the steps are working, except Take a Photo or Video is asking for Storage permission, and that leads to nowhere in system settings where it can be enabled! Looked through System Settings -> Apps and through Privacy -> Permissions Manager. Happening on both JP and WP.

Seems the Storage permission is asked due to the logic when taking a photo from the editor:

WordPress-Android/libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java

Lines 284 to 287 in 8a07a96

    
           @Override 
        
           public void onCapturePhotoButtonClicked() { 
        
               checkAndRequestCameraAndStoragePermissions(CAPTURE_PHOTO_PERMISSION_REQUEST_CODE); 
        
           }

WordPress-Android/libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java

Lines 774 to 775 in 8a07a96

    
           private void checkAndRequestCameraAndStoragePermissions(int permissionRequestCode) { 
        
               if (PermissionUtils.checkAndRequestCameraAndStoragePermissions(this,

It relies on PermissionUtils.checkAndRequestCameraAndStoragePermissions , which as far as I checked, it tries to access android.permission.WRITE_EXTERNAL_STORAGE permission.

@irfano @ravishanker Maybe a potential workaround would be to apply a similar approach like this one on the PermissionUtils class, WDYT?

WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/media/MediaBrowserActivity.java

Lines 1006 to 1012 in bb26d70

    
           String[] permissions = null; 
        
           if (item == AddMenuItem.ITEM_CAPTURE_PHOTO || item == AddMenuItem.ITEM_CAPTURE_VIDEO) { 
        
               if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) { 
        
                   permissions = new String[]{Manifest.permission.CAMERA}; 
        
               } else { 
        
                   permissions = new String[]{Manifest.permission.CAMERA, Manifest.permission.WRITE_EXTERNAL_STORAGE}; 
        
               }

irfano · 2023-03-29T00:47:41Z

Thank you so much for the help @fluiddot! I thought the change was required on gutenberg-mobile but it was on Utils library as you said.
I opened a PR on Utils library, and it fixed the camera issue on this PR.

irfano · 2023-03-29T00:55:09Z

@ravishanker, I updated the Utils library, and the camera permission issue should be fixed now.

ravishanker · 2023-03-29T02:25:11Z

@ravishanker, I updated the Utils library, and the camera permission issue should be fixed now.

Yes, working now.

Published a new version of Utils 3.5.0, please update it.

pachlava

@irfano 👋

Just leaving a note that mobile-ui-testing-squad was pinged for a review because the PR removes the write permission from two UI tests-related file. This does not seem to affect the execution negatively, so from our side, it's good to go as well 🙂

AjeshRPai · 2023-03-29T16:32:30Z

Hey @irfano

Nice work. 🙌🏼 . I have tested the app on Android 12, Pixel, and Android 13, Samsung.

While the positive scenario(all permissions granted) works in all the cases on both the devices, I found a behavior in Android 13, Samsung. I am not sure if it's right. More details below

Permissions	Media → + icon → Choose from device Screen
Audio and Music Permission - Allowed ✅ Photos and Videos Permission - Dont Allow ❌
Audio and Music Permission - Don't allow ❌ Photos and Videos Permission - Allow ✅

I haven't worked on the permissions for some time, so I am not sure what the issue is or whether this is to be expected.

irfano · 2023-03-30T18:42:21Z

While the positive scenario(all permissions granted) works in all the cases on both the devices, I found a behavior in Android 13, Samsung. I am not sure if it's right. More details below

🤔 Thank you for testing, @AjeshRPai! Can you see photos even though permission for the "Photos & videos" is not allowed? I tested it on both the emulator and the Android 13 Samsung device but couldn't reproduce your case. Can you write me testing instructions to reproduce it?

AjeshRPai · 2023-03-31T07:31:32Z

Hey Irfan 👋🏼

I can see some photos even when the permission Photos and Videos is not allowed and Audio and Music is allowed. When I am not allowing the permission Audio and Music, I cannot see anything even when Photos and Video permission is allowed

Steps to reproduce

Deny the permissions Photos and Videos and Audio and Music
Go to Dashboard → Media → + icon → Choose from device
Verify that the permission dialog is open → Deny the permission
Put the app in background
Go to the System settings → Allow Photos and Videos and don't allow Audio and Music
Go to the app → Notice that no photos or images are shown on Screen
Go to the System settings → Change Photos and Videosto Don't allow and allow Audio and Music
Go to the app → Notice that some photos are shown

Here the Audio and Music seems to be the breaker in showing the Photos, My instinct is that in Android 13 either,

We need the Audios and Music permission to access photos and video.
- In that case, we need to update the messaging to include Audio and Music on screen from the current implementation in this PR to the one similar in this PR raised by @0nko .
We don't need the Audios and Music permission, but we are incorrectly checking the status of Audio and Music permission before showing the photos and videos on media picker.

Current permission message	Permission message shown in this PR

@irfano I will spend some additional time checking whether I can reproduce the scenario I have described here . I will make sure to let you know with a comment.

AjeshRPai · 2023-03-31T07:59:29Z

WordPress/src/main/java/org/wordpress/android/ui/photopicker/MediaPickerLauncher.kt

@@ -192,7 +187,8 @@ class MediaPickerLauncher @Inject constructor(
            primaryDataSource = DEVICE,
            availableDataSources = setOf(),
            canMultiselect = canMultiselect,
-            requiresStoragePermissions = true,
+            requiresPhotosVideosPermissions = false,


❓I believe this is the function that's being called when you navigate from Media → + Icon → Choose from Device. Is the requiresPhotosVideosPermissions having correct value here?.

I did a quick run and test after changing this requiresPhotosVideosPermissions to true. I was able to see the photos in the Scenario

Allowed Photos and Video & Dont allow Audio and Music - I can see the photos and videos

Dont allow Photos and Video & Allow Audio and Music - I can't see any photos and video, Permission message is shown

Dont allow both permissions - Permission message is shown

Thank you so much for testing and finding a critical problem with the implementation, @AjeshRPai!
I added the support for "Image picker" or "Audio picker" but not for "Image + video + audio picker".
Now, I have added all media support to the media picker: ac21e3c.

AjeshRPai · 2023-03-31T08:02:52Z

@irfano

I have tested the app again, I can reproduce this issue. ✅ I have ensured that I am on the correct branch, and the Android version is 13.

📹 Please find below the video capture of this issue.

WhatsApp.Video.2023-03-31.at.12.53.58.PM.mp4

I looked into this issue, and I think I found the cause of the issue and left a suggestion here. I didn't commit the change. You can verify and make the change yourself. Feel free to let me know if you need anything else from me.

Warning Message: "WRITE_EXTERNAL_STORAGE no longer provides write access when targeting Android 11+, even when using 'requestLegacyExternalStorage'" Explanation: "Scoped storage is enforced on Android 10+ (or Android 11+ if using requestLegacyExternalStorage). In particular, WRITE_EXTERNAL_STORAGE will no longer provide write access to all files; it will provide the equivalent of READ_EXTERNAL_STORAGE instead." ------------------------------------------------------------------------ This warning is already addressed and will be fixed as part of the ongoing Android 13 media permissions work (see PR below): PR: #18183

…13)' into android-13-media-permissions # Conflicts: # build.gradle

irfano · 2023-04-03T22:42:04Z

I discovered another issue: the 'Story post' screen was not functioning properly.
I fixed it with the following commit: 898b117.
Additionally, I included it in the testing instructions. However, it can only be tested once Automattic/stories-android#731 is ready.

0nko · 2023-04-05T12:50:52Z

Hey there! 👋 Looking at this PR, I've been wondering why WPAndroid has its own version of the Media Picker instead of the using the library, which was designed to be customizable and reusable across different apps.

Is there anything specific that the library doesn't have or why it can't be integrated?

irfano · 2023-04-05T23:08:45Z

Hey there! 👋 Looking at this PR, I've been wondering why WPAndroid has its own version of the Media Picker instead of the using the library, which was designed to be customizable and reusable across different apps.

Is there anything specific that the library doesn't have or why it can't be integrated?

The reason for not using the MediaPicker library previously was that it required Hilt, which was not available when I attempted to add the Media Picker library to WPAndroid.

Now we have Hilt on WPAndroid, and we can add the library. I'll create an issue. Thanks for bringing it up, @0nko.

Btw, I recall we discussed this exact topic before. 😅 (Internal ref: p1637924023002400-slack-C02814L5EGP)

0nko · 2023-04-06T07:45:49Z

Btw, I recall we discussed this exact topic before. 😅 (Internal ref: p1637924023002400-slack-C02814L5EGP)

Good memory, it was 2.5 years ago. I completely forgot 😆

AjeshRPai

Hey @irfano

I have tested the app for the Media permissions, everything looks good to me 👍🏼

I have tested all the features by enabling/disabling permissions, and everything works as expected. I was able to select and upload photos and video when given permission and I was shown the message to allow permissions when I disabled the permissions.

The following features works as expected.

Media picker ✅
Media browser ✅
Story ✅

Thanks for working on this. I have left a Nitpick for you to address. Feel free to merge it once you had a look at it. I am approving but not merging so that you can have a look at the Nitpick I have left.

AjeshRPai · 2023-04-06T12:56:04Z

WordPress/src/main/res/values/strings.xml

@@ -2850,6 +2854,10 @@
    <string name="permissions_denied_title">Permissions</string>
    <string name="permissions_denied_message">It looks like you turned off permissions required for this feature.&lt;br/&gt;&lt;br/&gt;To change this, edit your permissions and make sure &lt;strong&gt;%s&lt;/strong&gt; is enabled.</string>
    <string name="permission_storage">Storage</string>
+    <string name="permission_images">Photos and videos</string>
+    <string name="permission_video">Photos and videos</string>


nip 🔍 : cant we reference the pemission_images string here?. Like

<string name="permission_video" translatable="false">@string/permission_images </string>

Thanks for the idea. I've done it: 21f9975

peril-wordpress-mobile · 2023-04-06T15:37:36Z

	Warnings
⚠️	PR has more than 300 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

irfano · 2023-04-06T20:33:14Z

I have also updated the RELEASE-NOTES.
Thank you all for reviewing. I am now merging.

Warning Message: "WRITE_EXTERNAL_STORAGE no longer provides write access when targeting Android 11+, even when using 'requestLegacyExternalStorage'" Explanation: "Scoped storage is enforced on Android 10+ (or Android 11+ if using requestLegacyExternalStorage). In particular, WRITE_EXTERNAL_STORAGE will no longer provide write access to all files; it will provide the equivalent of READ_EXTERNAL_STORAGE instead." ------------------------------------------------------------------------ This warning is already addressed and will be fixed as part of the ongoing Android 13 media permissions work (see PR below): PR: #18183

irfano added 4 commits March 27, 2023 17:59

Remove WRITE_EXTERNAL_STORAGE from tests

8db0d91

WRITE_EXTERNAL_STORAGE is not required for SDK higher than 29.

Use media permissions on media picker

ea209eb

For devices with API 33 and higher, we must request one or more of the granular media permissions instead of the READ_EXTERNAL_STORAGE permission.

Use media permissions on media browser

324c4c0

For devices with API 33 and higher, we must request one or more of the granular media permissions instead of the READ_EXTERNAL_STORAGE permission.

Update WRITE_EXTERNAL_STORAGE usage for newer APIs on advertiseImageO…

bb26d70

…ptimization

irfano added the Android 13 label Mar 27, 2023

irfano added this to the 22.1 milestone Mar 27, 2023

irfano requested a review from ravishanker March 27, 2023 22:06

irfano requested a review from a team as a code owner March 27, 2023 22:06

ravishanker assigned irfano Mar 28, 2023

AjeshRPai self-requested a review March 28, 2023 04:32

irfano mentioned this pull request Mar 29, 2023

Update media permissions for Android 13 wordpress-mobile/WordPress-Utils-Android#126

Merged

Update Utils library reference

e8de8bb

ravishanker approved these changes Mar 29, 2023

View reviewed changes

pachlava approved these changes Mar 29, 2023

View reviewed changes

ravishanker mentioned this pull request Mar 30, 2023

Android 13 fix media permissions Automattic/stories-android#731

Merged

AjeshRPai reviewed Mar 31, 2023

View reviewed changes

Add all media types support to the media picker

ac21e3c

irfano modified the milestones: 22.1, 22.2 Apr 3, 2023

irfano added 2 commits April 4, 2023 00:51

Migrate permissions in photo picker to Android 13

898b117

Merge branch 'Parent-PR-for-updating-targetSdkVersion-to-33-(Android-…

65737b2

…13)' into android-13-media-permissions # Conflicts: # build.gradle

irfano requested a review from AjeshRPai April 3, 2023 22:29

AjeshRPai approved these changes Apr 6, 2023

View reviewed changes

irfano added 2 commits April 6, 2023 18:35

Update permission_video string resource

21f9975

Update RELEASE-NOTES

d14b738

Resolve "translatable="false" warning on a string

8b50e67

irfano merged commit a76ef47 into Parent-PR-for-updating-targetSdkVersion-to-33-(Android-13) Apr 6, 2023

irfano deleted the android-13-media-permissions branch April 6, 2023 20:33

This was referenced Apr 17, 2023

[Lint Warnings] Source Set: Main - Resolve All Warnings [Correctness] - Part.1 #18245

Merged

Fix camera permission issue #18290

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android 13 media permissions #18183

Android 13 media permissions #18183

irfano commented Mar 27, 2023 •

edited

Loading

wpmobilebot commented Mar 27, 2023 •

edited

Loading

wpmobilebot commented Mar 27, 2023 •

edited

Loading

ravishanker commented Mar 28, 2023 •

edited

Loading

fluiddot commented Mar 28, 2023

irfano commented Mar 29, 2023 •

edited

Loading

irfano commented Mar 29, 2023

ravishanker commented Mar 29, 2023

pachlava left a comment

AjeshRPai commented Mar 29, 2023 •

edited

Loading

irfano commented Mar 30, 2023

AjeshRPai commented Mar 31, 2023

AjeshRPai Mar 31, 2023

irfano Apr 3, 2023

AjeshRPai commented Mar 31, 2023 •

edited

Loading

irfano commented Apr 3, 2023

0nko commented Apr 5, 2023

irfano commented Apr 5, 2023

0nko commented Apr 6, 2023

AjeshRPai left a comment

AjeshRPai Apr 6, 2023

irfano Apr 6, 2023

peril-wordpress-mobile bot commented Apr 6, 2023 •

edited

Loading

irfano commented Apr 6, 2023

Android 13 media permissions #18183

Android 13 media permissions #18183

Conversation

irfano commented Mar 27, 2023 • edited Loading

Regression Notes

wpmobilebot commented Mar 27, 2023 • edited Loading

wpmobilebot commented Mar 27, 2023 • edited Loading

ravishanker commented Mar 28, 2023 • edited Loading

fluiddot commented Mar 28, 2023

irfano commented Mar 29, 2023 • edited Loading

irfano commented Mar 29, 2023

ravishanker commented Mar 29, 2023

pachlava left a comment

Choose a reason for hiding this comment

AjeshRPai commented Mar 29, 2023 • edited Loading

irfano commented Mar 30, 2023

AjeshRPai commented Mar 31, 2023

AjeshRPai Mar 31, 2023

Choose a reason for hiding this comment

irfano Apr 3, 2023

Choose a reason for hiding this comment

AjeshRPai commented Mar 31, 2023 • edited Loading

irfano commented Apr 3, 2023

0nko commented Apr 5, 2023

irfano commented Apr 5, 2023

0nko commented Apr 6, 2023

AjeshRPai left a comment

Choose a reason for hiding this comment

AjeshRPai Apr 6, 2023

Choose a reason for hiding this comment

irfano Apr 6, 2023

Choose a reason for hiding this comment

peril-wordpress-mobile bot commented Apr 6, 2023 • edited Loading

irfano commented Apr 6, 2023

irfano commented Mar 27, 2023 •

edited

Loading

wpmobilebot commented Mar 27, 2023 •

edited

Loading

wpmobilebot commented Mar 27, 2023 •

edited

Loading

ravishanker commented Mar 28, 2023 •

edited

Loading

irfano commented Mar 29, 2023 •

edited

Loading

AjeshRPai commented Mar 29, 2023 •

edited

Loading

AjeshRPai commented Mar 31, 2023 •

edited

Loading

peril-wordpress-mobile bot commented Apr 6, 2023 •

edited

Loading