[Migrate] Kotlin Android Extensions to ViewBinding #3057
Conversation
FYI: This refactor also fixes a few bugs where a view id from 'fragment_woo_batch_update_variations' was used instead of using the correct with, with the same view id, from the actual targeted 'fragment_woo_batch_generate_variations' fragment.
As part of this, the deprecated parcelize import got also replaced.
As part of this, the deprecated parcelize import got also replaced.
FYI: This change was done for testing purposes and until the below 'Android Dependency Catalog' #32 PR gets merged to 'trunk'. When that's done, the 'catalogVersion' will be updated to '1.17.0' instead. ------------------------------------------------------------------------ Android Dependency Catalog PR: [Migrate] Kotlin Android Extensions to Kotlin Parcelize #32 - Automattic/android-dependency-catalog#32
There was a problem hiding this comment.
Looks good, great work @ParaskP7 🙌 . Thanks for improving some log messages along the way.
btw: during the review, I started to wonder how often the example app in FluxC is used nowadays. Maybe it's something we could discuss internally what's the future for this module.
Not merging as I understand we need to update versions catalog 👍
Awesome, thanks for the quick review @wzieba ! 🙇 ❤️
Hmmm, to my understanding, to some extend, but to be honest, I am actually not sure. I bet sometimes it might help to use this We could ask JP/WPAndroid and WCAndroid devs this question directly and get a quick feedback on it. 🤔
👍 💯
Yes, thanks you, I am in the process of creating the new 1.17.0 release, will then push an update commit and merge it myself. 👍 |
Depends On:
1.17.0Description
This PR is about migrating from the deprecated
kotlin-android-extensionsplugin, replacing Kotlin synthetics with ViewBinding and usingkotlin-parcelizeinstead.FYI: The
kotlin-android-extensionsplugin has been deprecated for years now and it is now preventing us from updating to a newer Kotlin version (ie. Kotlin 1.9.25).To Test
FluxC Exampleapp, try out all available screens and functionality. Verify everything is working as expected.kotlinx.parcelize.Parcelizeimport change, you could quickly smoke test, either the JP/WPAndroid and/or WCAndroid, with this version ofFluxC, or via composite builds, and see if it works as expected.