[Dependency Analysis] Add Android Gradle Plugin #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI: This commit adds a previous version of the plugin (1.28.0) and not the latest version (1.32.0). This is because the latest version gets stuck during the 'computeActualUsage' phase and increases the build time of the 'buildHealth' task by as much as five times (5x). For more info see: Stuck in computeActualUsageDebug for many minutes #1186 (https://github.com/autonomousapps/ dependency-analysis-gradle-plugin/issues/1186)
As per the documentation, this change follows the below step within the 'Adding a new dependency' section: "If this is a new plugin, add it under plugins section in example/build.gradle.kts - make sure to add .apply(false). This step is necessary because we use the example module to generate a dependency cache we use to speed up CI in other projects. We are able to automatically add the library dependencies, so this step is not necessary, but plugins need to be added manually."
|
Closing this as the FYI: I went and really quickly tried to update FluxC to In general, I wouldn't recommend bumping Kotlin just for this plugin to work. Updating Kotlin should be considered another major task for FluxC and should be done in isolation to anything else. |
ParaskP7
added a commit
to wordpress-mobile/WordPress-FluxC-Android
that referenced
this pull request
Jul 24, 2024
FYI: This change was done for testing purposes and until the below 'Android Dependency Catalog' #32 PR gets merged to 'trunk'. When that's done, the 'catalogVersion' will be updated to '1.19.0' instead. ------------------------------------------------------------------------ Android Dependency Catalog PR: [Migrate] [Dependency Analysis] Add Android Gradle Plugin #31 - Automattic/android-dependency-catalog#31 ------------------------------------------------------------------------ FYI: This commit adds a previous version of the plugin (1.28.0) and not the latest version (1.32.0). This is because the latest version gets stuck during the 'computeActualUsage' phase and increases the build time of the 'buildHealth' task by as much as five times (5x). For more info see: Stuck in computeActualUsageDebug for many minutes #1186 (https://github.com/autonomousapps/ dependency-analysis-gradle-plugin/issues/1186)
Merged
2 tasks
|
👋 @wzieba and FYI that I reopened this PR and it is now ready for another go! 🙏 |
wzieba
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Thread: paaHJt-6yU-p2
Required By: FluxC#TODO
Description
Adds Dependency Analysis plugin to be used for the WordPress-FluxC-Android repo (see
Required By).To test (FluxC PR):
exampleapp.