Strips semantic version information in GSS version check #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevins
reviewed
Jun 29, 2021
| wordPressSoftwareVersion.substringBefore("-") | ||
| } else wordPressSoftwareVersion | ||
| Version(version) >= Version(GSS_LIMIT_VERSION) | ||
| } catch (e: IllegalArgumentException) { |
There was a problem hiding this comment.
Good idea to add this bit of robustness. 👍
3 tasks
mkevins
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress-AndroidPR: wordpress-mobile/WordPress-Android#14963Description
This PR works around the limitation of our Version utility in handling semantic versions (e.g.
5.8-beta4-51251) by stripping the extra information and keeping only the numeric version string (e.g.5.8). This applies only in the specific use case of checking the WordPress software version number for enabling GSS.To test
Reproduce the crash
5.8-beta4) site or a self-hosted site with beta WordPress versionVerify the fix
5.8-beta4) site or a self-hosted site with beta WordPress version