Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global Styles] Fixes WordPress version check crash #14963

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Jun 29, 2021

Depends on:

Description

This PR works around the limitation of our Version utility in handling semantic versions (e.g. 5.8-beta4-51251) by stripping the extra information and keeping only the numeric version string (e.g. 5.8). This applies only in the specific use case of checking the WordPress software version number for enabling GSS.

To test:
Follow the test instructions at wordpress-mobile/WordPress-FluxC-Android#2041

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis requested review from geriux and mkevins June 29, 2021 10:43
@antonis antonis self-assigned this Jun 29, 2021
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 29, 2021

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved via: wordpress-mobile/WordPress-FluxC-Android#2041 (review)

Thanks for the fix Antonis!

@geriux geriux merged commit 37eb911 into develop Jun 30, 2021
@geriux geriux deleted the fix/gss-version-check branch June 30, 2021 10:39
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@geriux geriux added this to the 17.8 milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants