Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Gutenberg mobile strings for translation #9275

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Edit Gutenberg mobile strings for translation #9275

merged 1 commit into from
Feb 19, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Feb 19, 2019 •
edited
Loading

Follow up of #9214

This updates the gutenberg strings after WordPress/gutenberg#13880 was merged

@Tug Tug self-assigned this Feb 19, 2019
@Tug Tug requested a review from koke February 19, 2019 08:50
@wpmobilebot
Copy link
Contributor

2 Warnings
⚠️ PR is missing at least one label.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@Tug Tug mentioned this pull request Feb 19, 2019
Merged
@Tug Tug added gutenberg-mobile Gutenberg Editing and display of Gutenberg blocks. labels Feb 19, 2019
@Tug Tug added this to the 11.9 milestone Feb 19, 2019
@hypest
Copy link
Contributor

hypest commented Feb 19, 2019

As per @Tug , the %s strings placeholder have already been tested and working with the Gutenberg code so, will give this the 👍 so we can send it to GlotPress as early as possible.

hypest
hypest approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tug Tug merged commit 976ed15 into develop Feb 19, 2019
@Tug Tug deleted the add/gutenberg-mobile-strings branch February 19, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

@koke koke Awaiting requested review from koke

Assignees

@Tug Tug

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
11.9 ❄️
Development

Successfully merging this pull request may close these issues.
3 participants
@Tug @wpmobilebot @hypest