Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gutenberg mobile strings for translation #9214

Merged
merged 7 commits into from
Feb 18, 2019
Merged

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Feb 11, 2019

This PR manually adds the strings that needs to be translated in gutenberg-mobile to res/values/strings.xml which will thus be added to the WordPress Android glotpress project.

This PR manually adds the strings that needs to be translated in `gutenberg-mobile` to `PlayStoreStrings.po` which will thus be added to the WordPress Android glotpress project.
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@Tug Tug requested a review from koke February 13, 2019 13:17
@koke
Copy link
Member

koke commented Feb 14, 2019

This looks good to me, but I don't have enough Android experience, I'd like to see a 👍 from @wordpress-mobile/platform-9

@loremattei
Copy link
Contributor

Yep! Strings look good to me.
The CI is failing because of the linter. Maybe the regex in lint.xml doesn't match?

@koke
Copy link
Member

koke commented Feb 15, 2019

Maybe the regex in lint.xml doesn't match?

It looks to me like the ignore option deals with filenames, not string IDs

@koke
Copy link
Member

koke commented Feb 15, 2019

I've pushed 257500a which seems to solve the lint issues locally, let's see what Circle has to say

@loremattei
Copy link
Contributor

Oh, I'm sorry I didn't make it clear enough (I thought I did, but re-reading my comment I see it's not): It works with file content as well, but the input string is the whole line. So the regex didn't match because of the ^. This is the reason I hadn't put it in the solution I posted on slack.

Anyway, your solution works as well and to be honest I think it's better because it keeps all the changes in the same file. Since we plan to change the way we handle the translations for these strings in the future, this way we don't risk to leave unused rules in lint.xml when we'll switch.

I'd say :shipit: 👍

Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused since this is still marked not ready for review but Lorenzo has given a 👍 already, so approving in case it's waiting on me

@Tug Tug merged commit f360c24 into develop Feb 18, 2019
@Tug Tug deleted the add/gutenberg-mobile-strings branch February 18, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants