-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gutenberg mobile strings for translation #9214
Conversation
This PR manually adds the strings that needs to be translated in `gutenberg-mobile` to `PlayStoreStrings.po` which will thus be added to the WordPress Android glotpress project.
Generated by 🚫 Danger |
This looks good to me, but I don't have enough Android experience, I'd like to see a 👍 from @wordpress-mobile/platform-9 |
Yep! Strings look good to me. |
It looks to me like the |
I've pushed 257500a which seems to solve the lint issues locally, let's see what Circle has to say |
Oh, I'm sorry I didn't make it clear enough (I thought I did, but re-reading my comment I see it's not): It works with file content as well, but the input string is the whole line. So the regex didn't match because of the Anyway, your solution works as well and to be honest I think it's better because it keeps all the changes in the same file. Since we plan to change the way we handle the translations for these strings in the future, this way we don't risk to leave unused rules in I'd say 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused since this is still marked not ready for review but Lorenzo has given a 👍 already, so approving in case it's waiting on me
This PR manually adds the strings that needs to be translated in
gutenberg-mobile
tores/values/strings.xml
which will thus be added to the WordPress Android glotpress project.