-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetpack Content Migration Flow] Add Notifications Screen to the flow #17435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovitrif
changed the title
Issue/17372 jp migration notifications screen
[Jetpack Content Migration Flow] Add Notifications Screen to the flow
Nov 7, 2022
📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17435-e7dd931.apk
|
📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17435-e7dd931.apk
|
ovitrif
force-pushed
the
issue/17372-jp-migration-notifications-screen
branch
from
November 9, 2022 12:23
4da4453
to
a0a8ed6
Compare
ovitrif
force-pushed
the
issue/17368-jp-migration-welcome-screen-design-updates
branch
from
November 9, 2022 13:21
2116a45
to
809738d
Compare
ovitrif
force-pushed
the
issue/17372-jp-migration-notifications-screen
branch
from
November 9, 2022 13:43
a0a8ed6
to
e7dd931
Compare
ovitrif
commented
Nov 9, 2022
Base automatically changed from
issue/17368-jp-migration-welcome-screen-design-updates
to
trunk
November 10, 2022 11:12
Generated by 🚫 dangerJS |
antonis
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ovitrif 👍
I've tested the app on a Pixel 5 (Android 13) both with the JETPACK_MIGRATION_FLOW
true
and false
and everything worked as expected. The code changes also LGTM 🎉
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Partially #17372 (doesn't disable notifications in WP which is wip in #17371 nor navigates to next step).
This PR implements the UI for the notifications step in the WordPress to Jetpack migration flow.
It also adds crossfade transition between the migration flow screens.
To test:
Me
→App Settings
→Debug Settings
JetpackMigrationFlowFeatureConfig
& restart the app.Continue
button on the "Welcome to Jetpack!" screenContinue
button has no functionality in this PR, that's handled in #17440.Previews
Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
N/a
What automated tests I added (or what prevented me from doing so)
None - PR adds only UI and UI state changes.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.