Jetpack focus: Disable push notifications for WP

[ravishanker]

If an instance of JP is detected then disable push notifications for WP to prevent double notifications

• Trigger this from Jetpack app, on notifications screen in the welcome flow in a separate PR ( See example )
• Add permissions to exported BroadcastReceiver. Preferably, signature, otherwise normal in a separate PR

To test:

Test 1:

• Ensure either Jetpack app or Jetpack beta app is installed
• Ensure WordPress app is also on the device
• Ensure you already receive some push notifications

Test 2:

• Remove any WordPress app instances
• Build and Run WordPress app or install using QR code below
• Open Terminal in AS or Terminal app. Execute adb shell am broadcast -p org.wordpress.android.prealpha -a org.wordpress.android.broadcast.DISABLE_NOTIFICATIONS command (Welcome flow is still in the works, till then use command line to test it on WP side)
• Verify Action: org.wordpress.android.broadcast.DISABLE_NOTIFICATIONS is displayed in a toast message on the app. The same can be seen in the Logcat in AS
• Verify switch is set to Off on Notification Settings ( Me > Notifications tab > ⚙️ on the top right hand corner )
• Wait till the next day if required or push a debug notification
• Verify push notifications are not displayed for WordPress app
• Ensure notifications are displayed for Jetpack app as before.

NOTE: this doesn't cover any local notifications e.g. WeeklyRoundup

Regression Notes

1. Potential unintended areas of impact
   None

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Tested manually

3. What automated tests I added (or what prevented me from doing so)
   Existing tests

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17371-2626fc0.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	WordPress
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	2626fc0

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[wpmobilebot]

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17371-2626fc0.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	Jetpack
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	2626fc0

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[staskus]

Once this disables notifications on WordPress app, does it get reflected in the Notification Settings view, showing disabled On flag?

[ravishanker]

Good point. this PR is only aimed at testing the disabling notifications actually works for now.

[irfano]

Thanks, Ravi! This only removed received notifications when the WordPress app is launched. We will prevent receiving new WP notifications. But there is a case that users can install the Jetpack app when they already have received WP notifications. This PR handles only this case, right?

The function works on my test. 👍🏻 I just commented for some code changes.

[ravishanker]

@irfano - I've updated the implementation to use a BroadcastReceiver to trigger this from Jetpack app, after install, login, and when in the welcome flow. wdyt?

This approach has advantage of removing the need for detecting Jetpack app install, login, and inform steps.

Welcome flow is still in the works, till then we can hook this somewhere on the Jetpack app side temporarily to test it out. Updated instructions in the description

[irfano]

Looks great! This is a clever solution. 👏🏻
I tested sending broadcast, and it worked. The notification switch was turned off successfully. But while testing, I couldn't receive push notifications for WP, even when the switch was on. I'll test it again.

[staskus]

I've updated the implementation to use a BroadcastReceiver to trigger this from Jetpack app, after install, login, and when in the welcome flow. wdyt?

Great news! iOS and Android solutions could pretty much match then. We can even align on conditions when to trigger this from Jetpack app 👍

[irfano]

• I moved JetpackAppInstallReceiver to wordpress directory. Since it will work only in WP app,
• I added org.wordpress.android.permission.DISABLE_NOTIFICATIONS permission,
• Removed debug logging,
• Synced with trunk,
• Tested it with this code block, and it worked. But the package name should align with the build variant.

Intent().also { intent ->
    intent.action = "org.wordpress.android.broadcast.DISABLE_NOTIFICATIONS"
    intent.package = "org.wordpress.android"   
    context?.sendBroadcast(intent, "org.wordpress.android.permission.DISABLE_NOTIFICATIONS")
}

[ravishanker]

* Tested it with this code block, and it worked. But the package name should align with the build variant.

I tried something like this earlier

val appSuffix = BuildConfig.APPLICATION_ID.split(".").last()
            val appPackage = if (appSuffix.isNotBlank()) {
                "org.wordpress.android.${appSuffix}"
            } else {
                "org.wordpress.android"
            }
            intent.setPackage(appPackage)
            AppLog.d(T.NOTIFS, intent.toString())