[Site Intent Question] String corrections and input sanitisation #16282
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APKs: |
| <string name="new_site_creation_intents_header_subtitle">Choose a topic from the list below or type your own</string> | ||
| <string name="new_site_creation_intents_input_hint">Eg. Fashion, Poetry, Politics</string> | ||
| <string name="new_site_creation_intents_header_subtitle">Choose a topic from the list below or type your own.</string> | ||
| <string name="new_site_creation_intents_input_hint">E.g. Fashion, Poetry, Politics</string> |
There was a problem hiding this comment.
Note: the wording changes won't get into GlotPress in time for 19.6, as the translation process has already started last week and strings have already been sent to our translation vendor over the weekend.
This means that the English copy will have this typo fixed in 19.6, but the translations will be based on the old English copy (though the translators might already have fixed this missing . in their translation, especially if e.g. translates to another abbreviation in their locale)
There was a problem hiding this comment.
Thank you for the clarification @AliSoftware 🙇
|
FYI: This fix made it to 19.6-rc-3. |
Description
This PR:
Eg.toE.g.and adds a period at the end of the site intent subtitleTo test:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
Added a couple new unit tests with 8c78c8a
PR submission checklist:
RELEASE-NOTES.txtif necessary.