Update the format sytext in github workflow #15792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APKs: |
|
It seems this flow reached an idempotent action when creating the PR (it already existed), it tried to update it:
And the text looks the same, I guess because it is the same 😄 , but it does seem to be in the edit history:
|
|
So, I tried with "test" in the body, and it updates:
Then again, with blank body:
And it is restored back to what it was originally.
|
mkevins
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #15791
This PR tries to fix the generated PR description that gets generated by the workflow.
To test:
Visit https://github.com/wordpress-mobile/WordPress-Android/actions/workflows/automated-version-update-pr.yml
Set the Worflow to use the following
branch: fix/github-workflow-update-format
gutenbergMobileVersion: 4350-930a73b8a6c964df202603f619099943714ab32d
title: Gutenberg Mobile wordpress-mobile/gutenberg-mobile#4350
prURL: wordpress-mobile/gutenberg-mobile#4350
leave body empty.
See
The result of this this is the following PR.
#15793
🤞 that it works?
Regression Notes
Potential unintended areas of impact
none.
What I did to test those areas of impact (or what existing automated tests I relied on)
none.
What automated tests I added (or what prevented me from doing so)
none.
PR submission checklist:
RELEASE-NOTES.txtif necessary.