Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gutenberg mobile workflow #15791

Merged
merged 4 commits into from
Jan 4, 2022
Merged

Fix gutenberg mobile workflow #15791

merged 4 commits into from
Jan 4, 2022

Conversation

enejb
Copy link
Contributor

@enejb enejb commented Jan 4, 2022

  • Fixes the workflow by updating the sed command to replace the correct.

To test:
Merge and hope that it works!
🤞

Regression Notes

  1. Potential unintended areas of impact
    None that think of the workflow is currenty broken already.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    none.

  3. What automated tests I added (or what prevented me from doing so)
    none.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@enejb enejb requested review from oguzkocer and ttahmouch January 4, 2022 21:01
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 4, 2022 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@enejb enejb enabled auto-merge January 4, 2022 21:12
ttahmouch
ttahmouch approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@ttahmouch ttahmouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@enejb enejb merged commit 4768d54 into develop Jan 4, 2022
@enejb enejb deleted the fix/github-worflow-gutenberg-mobile-sed branch January 4, 2022 21:32
@enejb enejb mentioned this pull request Jan 4, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttahmouch ttahmouch ttahmouch approved these changes

@oguzkocer oguzkocer Awaiting requested review from oguzkocer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enejb @ttahmouch