Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Site Dashboard - Phase 2 - Update Error Card & Stale Message Style & Copy #15788

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Jan 4, 2022

Fixes #15785

Error Card Before Error Card After
error_card_before error_card_after
Stale Message Before Stale Message After Stale Message After (RTL)
before after_1 error_card_RTL

To test:

It is sufficient to

  • Compare updated strings in the strings.xml in commits 4fb3f41 (for error card) and 4c2ff9b (for stale message).
  • Compare before and after screenshots and review commit 0985613 for stale message style changes.

Merge Instructions:

  1. Make sure that the style updates are approved in the design review.
  2. Remove Not Ready for Merge, Needs Design Review labels.
  3. Merge the PR.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr added [Status] Needs Design Review A designer needs to sign off on the implemented design. [Status] Not Ready for Merge My Site Dashboard labels Jan 4, 2022
@ashiagr ashiagr added this to the 19.0 milestone Jan 4, 2022
@ashiagr ashiagr self-assigned this Jan 4, 2022
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@ParaskP7 ParaskP7 self-assigned this Jan 4, 2022
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @ashiagr !

I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟

PS: Feel free to merge this PR after the design review is done. 🟢

@ashiagr
Copy link
Contributor Author

ashiagr commented Jan 5, 2022

I'm merging this PR as Chris might not be able to respond before the 19.0 release due to leaves 👶 and considering it is a minor style update, already code reviewed. 🙂

Feel free to drop any comment, if anyone has.

@ashiagr ashiagr removed [Status] Needs Design Review A designer needs to sign off on the implemented design. [Status] Not Ready for Merge labels Jan 5, 2022
@ashiagr ashiagr merged commit 66bfb56 into develop Jan 5, 2022
@ashiagr ashiagr deleted the issue/15785-update-error-card-stale-msg-style-copy branch January 5, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Site Dashboard - Phase 2 - Update Error Card & Stale Message Style & Copy
2 participants