Skip to content

Commit

Permalink
Merge pull request #15788 from wordpress-mobile/issue/15785-update-er…
Browse files Browse the repository at this point in the history
…ror-card-stale-msg-style-copy

My Site Dashboard - Phase 2 - Update Error Card & Stale Message Style & Copy
  • Loading branch information
ashiagr authored Jan 5, 2022
2 parents 4768d54 + 2031ff2 commit 66bfb56
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ class MySiteCardAndItemDecoration(
val position = parent.getChildAdapterPosition(view)
if (position < 0) return
when (parent.adapter?.getItemViewType(position)) {
MySiteCardAndItem.Type.INFO_ITEM.ordinal -> {
outRect.top = verticalMargin
outRect.left = horizontalMargin
outRect.right = horizontalMargin
}
MySiteCardAndItem.Type.LIST_ITEM.ordinal,
MySiteCardAndItem.Type.CATEGORY_HEADER_ITEM.ordinal -> {
outRect.left = horizontalMargin
Expand Down
6 changes: 3 additions & 3 deletions WordPress/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2204,7 +2204,7 @@

<!-- My Site - Dashboard -->
<string name="my_site_dashboard_update_error">Couldn\'t update dashboard.</string>
<string name="my_site_dashboard_stale_message">Couldn\'t update dashboard. Check your connection and pull to refresh.</string>
<string name="my_site_dashboard_stale_message">The dashboard is not updated. Please check your connection and then pull to refresh.</string>

<!-- My Site - Post Card -->
<string name="my_site_post_card_draft_title">Work on a draft post</string>
Expand All @@ -2220,8 +2220,8 @@
<string name="my_site_post_card_link_go_to_scheduled_posts">Go to scheduled posts</string>

<!-- My Site - Error Card -->
<string name="my_site_error_card_title">Some data wasn\'t loaded</string>
<string name="my_site_error_card_subtitle">Couldn\'t display more data about your site right now.</string>
<string name="my_site_error_card_title">Some data hasn\'t loaded</string>
<string name="my_site_error_card_subtitle">We\'re having trouble loading your site\'s data at the moment.</string>

<!-- site picker -->
<string name="site_picker_title">Choose site</string>
Expand Down
2 changes: 1 addition & 1 deletion WordPress/src/main/res/values/styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@
</style>

<style name="MySiteInfoItemTextView">
<item name="android:textAlignment">center</item>
<item name="android:textAlignment">viewStart</item>
<item name="android:singleLine">false</item>
<item name="android:textAppearance">?attr/textAppearanceCaption</item>
<item name="android:textColor">?attr/wpColorOnSurfaceMedium</item>
Expand Down

0 comments on commit 66bfb56

Please sign in to comment.