Update stories - removal of deprecated kotlin-android-extensions #14928
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
|
Haven't tested the build yet, but I noticed the lint errors in the failing task were from the stories lib. Should be addressed in this PR: Automattic/stories-android#706 |
There was a problem hiding this comment.
Switched to the branch from Automattic/stories-android#706, and:
✅ lintWordpressVanillaRelease is green
✅ Smoke tested stories, everything continues to work smoothly
(assuming Automattic/stories-android#706 is merged and this PR is updated to stories-android develop after that)
There was a problem hiding this comment.
@malinajirka - I focused my testing on the build: added new stories, updated stories, text placement, size, color, single images, multiple images, previewing, sharing. Everything is working as expected. 👍
|
Awesome thank you both! 🙇 |
|
cc @oguzkocer it seems all usages of |
This PR updates stories library to the current
stories/develop. The changes in the stories library have already been tested. The changes are related to the replacement of kotlin synthetic accessors with view bindings and removal of deprecatedkotlin-android-extensions.To test:
Smoke test stories
cc @oguzkocer When this PR gets merged, it should hopefully unblock your effort to update AGP.
Regression Notes
Potential unintended areas of impact
Stories
What I did to test those areas of impact (or what existing automated tests I relied on)
I've tried adding images from various sources, adding texts, changing rotation/color/etc and publishing a story.
What automated tests I added (or what prevented me from doing so)
The changes touch just the UI layer so unit tests can't be added.
PR submission checklist:
RELEASE-NOTES.txtif necessary.