Address WPAndroid ClickableViewAccessibility lint errors #706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the view binding update (#688) created a few cases of the
ClickableViewAccessibility
lint check. Nothing changed feature-wise, I'm guessing the check just parses view binding based code differently and recognized something where it didn't before. I noticed this in wordpress-mobile/WordPress-Android#14928, which is trying to pull the view binding changes from this library into WPAndroid.ClickableViewAccessibility
is a warning by default, but WPAndroid has promoted this to an error.We have an open issue (#499) to eventually try to address some
ClickableViewAccessiblity
suppressions we already have, which I believe were imported with the original photoeditor library. (It may in fact be a true false positive in some cases due to how we're handling clicks.)For now, to unblock that PR, I'm suppressing the lint check in the areas where it's now being flagged. I've also imported the
lint.xml
file from WPAndroid to make this less likely to happen in the future (I removed a few obvious WPAndroid-specific things). Ideally this will be part of better tooling in the future allowing us to share thelint.xml
between projects with local custom rules.To test
lintWordpressVanillaRelease
, make sure there are no errors